Skip to content

Pillow: mark MAX_IMAGE_PIXELS as non-final#10445

Merged
AlexWaygood merged 2 commits into
python:mainfrom
DMRobertson:dmr/pillow-max-image-size
Jul 12, 2023
Merged

Pillow: mark MAX_IMAGE_PIXELS as non-final#10445
AlexWaygood merged 2 commits into
python:mainfrom
DMRobertson:dmr/pillow-max-image-size

Conversation

@DMRobertson
Copy link
Copy Markdown
Contributor

I don't think it was correct for #10411 to mark MAX_IMAGE_PIXELS as final. Quoting my reasoning from #10411 (comment):

According to pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.open:

This threshold can be changed by setting MAX_IMAGE_PIXELS. It can be disabled by setting Image.MAX_IMAGE_PIXELS = None.

I can't see any mention of this [MAX_IMAGE_PIXELS] in pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html either.

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DMRobertson DMRobertson marked this pull request as ready for review July 12, 2023 14:05
@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 338e067 into python:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants