Skip to content

Fix divider lines in stubtest_third_party.py#11799

Merged
JelleZijlstra merged 1 commit intopython:mainfrom
AlexWaygood:fix-stubtest-output
Apr 21, 2024
Merged

Fix divider lines in stubtest_third_party.py#11799
JelleZijlstra merged 1 commit intopython:mainfrom
AlexWaygood:fix-stubtest-output

Conversation

@AlexWaygood
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood commented Apr 20, 2024

Fixes #11763 (comment). Things were appearing out of order in CI because some things were being printed to stderr and other things to stdout. Also stubsabot is giving the wrong URL to the typeshed stubs in its PR summaries due to a silly typo that was also introduced in #11763 (see #11727 for an example of the bad link in the PR description).

Demonstration that proves printing everything to sys.stderr fixes the bug: AlexWaygood#30

@AlexWaygood AlexWaygood requested a review from Avasam April 20, 2024 22:18
@JelleZijlstra JelleZijlstra merged commit 4872c30 into python:main Apr 21, 2024
@AlexWaygood AlexWaygood deleted the fix-stubtest-output branch April 21, 2024 00:13
@AlexWaygood
Copy link
Copy Markdown
Member Author

Ah great, now everything's screwed up for the output of mypy_test.py: https://github.com/python/typeshed/actions/runs/8774293165/job/24075345197?pr=11802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants