stubtest_third_party.py, mypy_test.py: just print everything to stdout#11809
Merged
AlexWaygood merged 2 commits intopython:mainfrom Apr 22, 2024
Merged
stubtest_third_party.py, mypy_test.py: just print everything to stdout#11809AlexWaygood merged 2 commits intopython:mainfrom
stubtest_third_party.py, mypy_test.py: just print everything to stdout#11809AlexWaygood merged 2 commits intopython:mainfrom
Conversation
srittau
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GitHub Actions, all stderr appears above stdout, even if things are printed to stdout chronologically earlier than being printed to stderr. That is, if you have something like
The output in GitHub Actions will be
Recent changes I made to
stubtest_third_party.pymade the output go funny because some things were being printed to stderr in CI and some things to stdout. I fixed most of that in #11799, but not all of it (the output still isn't quite right in https://github.com/python/typeshed/actions/runs/8776498752), and now the output ofmypy_test.pyis all screwed up because of that fix (https://github.com/python/typeshed/actions/runs/8782468512/job/24096628717?pr=11808).I think it's easier if we just print everything to stdout rather than passing
file=sys.stderranywhere, because if you forget to do it in one place then you end up with bizarre output in CI. Ideally some of this information would be going to stderr rather than stdout, but I don't think it matters that much for our purposes; mostly our scripts are just keeping us up to date with where they're at.