Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4316
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 8 PendingAs of commit b0697ac with merge base bfa7a94 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 22, 2026
vkuzo
commented
Apr 22, 2026
| not torch_version_at_least("2.8.0"), | ||
| reason="torch.compile requires PyTorch 2.8+", | ||
| ) | ||
| def test_nvfp4_quantize_3d_param_similar_to_vllm(self): |
Contributor
Author
There was a problem hiding this comment.
this isn't used so deleting
drisspg
approved these changes
Apr 22, 2026
vkuzo
added a commit
that referenced
this pull request
Apr 23, 2026
Summary: for nvfp4 + grouped_mm: 1. hooks up mslk's to_nvfp4 quantization kernel for token group activations 2. hooks up the nvfp4 recipe of `torch._scaled_grouped_mm` still WIP Test Plan: ``` pytest test/prototype/mx_formats/test_inference_workflow.py -s -k grouped_mm ``` ghstack-source-id: 44d2809 ghstack-comment-id: 4299981698 Pull-Request: #4316
vkuzo
added a commit
that referenced
this pull request
Apr 23, 2026
Summary: for nvfp4 + grouped_mm: 1. hooks up mslk's to_nvfp4 quantization kernel for token group activations 2. hooks up the nvfp4 recipe of `torch._scaled_grouped_mm` still WIP Test Plan: ``` pytest test/prototype/mx_formats/test_inference_workflow.py -s -k grouped_mm ``` ghstack-source-id: 44d2809 ghstack-comment-id: 4299981698 Pull-Request: #4316
vkuzo
added a commit
that referenced
this pull request
Apr 23, 2026
Summary: for nvfp4 + grouped_mm: 1. hooks up mslk's to_nvfp4 quantization kernel for token group activations 2. hooks up the nvfp4 recipe of `torch._scaled_grouped_mm` still WIP Test Plan: ``` pytest test/prototype/mx_formats/test_inference_workflow.py -s -k grouped_mm ``` ghstack-source-id: 44d2809 ghstack-comment-id: 4299981698 Pull-Request: #4316
vkuzo
added a commit
that referenced
this pull request
Apr 23, 2026
Summary: for nvfp4 + grouped_mm: 1. hooks up mslk's to_nvfp4 quantization kernel for token group activations 2. hooks up the nvfp4 recipe of `torch._scaled_grouped_mm` still WIP Test Plan: ``` pytest test/prototype/mx_formats/test_inference_workflow.py -s -k grouped_mm ``` ghstack-source-id: 8d9fd1f ghstack-comment-id: 4299981698 Pull-Request: #4316
vkuzo
added a commit
that referenced
this pull request
Apr 23, 2026
Summary: for nvfp4 + grouped_mm: 1. hooks up mslk's to_nvfp4 quantization kernel for token group activations 2. hooks up the nvfp4 recipe of `torch._scaled_grouped_mm` still WIP Test Plan: ``` pytest test/prototype/mx_formats/test_inference_workflow.py -s -k grouped_mm ``` ghstack-source-id: cae5aae ghstack-comment-id: 4299981698 Pull-Request: #4316
This was referenced Apr 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
for nvfp4 + grouped_mm:
activations
torch._scaled_grouped_mmstill WIP
Test Plan: