Skip to content

wire up nvfp4 bmm#4320

Merged
vkuzo merged 43 commits intomainfrom
gh/vkuzo/256/head
Apr 23, 2026
Merged

wire up nvfp4 bmm#4320
vkuzo merged 43 commits intomainfrom
gh/vkuzo/256/head

Conversation

@vkuzo
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo commented Apr 23, 2026

Summary:

Wires up nvfp4 bmm with a for loop over nvfp4 mm's

We can hook up a faster kernel once we have one.

Test Plan:

pytest test/prototype/mx_formats/test_inference_workflow.py -s -k bmm

vkuzo added 30 commits April 20, 2026 20:52
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added 6 commits April 23, 2026 09:27
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo requested a review from danielvegamyhre as a code owner April 23, 2026 13:57
@vkuzo
Copy link
Copy Markdown
Contributor Author

vkuzo commented Apr 23, 2026

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4320

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2026
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Apr 23, 2026
Summary:

Wires up nvfp4 bmm with a for loop over nvfp4 mm's

We can hook up a faster kernel once we have one.

Test Plan:

```
pytest test/prototype/mx_formats/test_inference_workflow.py -s -k bmm
```
ghstack-source-id: 276eef4
ghstack-comment-id: 4304995737
Pull-Request: #4320
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if bmm is used right now actually, I feel we could delay this as well

vkuzo added 3 commits April 23, 2026 17:21
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo added the module: not user facing Use this tag if you don't want this PR to show up in release notes label Apr 23, 2026
vkuzo added 3 commits April 23, 2026 18:44
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/255/head to main April 23, 2026 18:45
@vkuzo vkuzo merged commit 79430ad into main Apr 23, 2026
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants