Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps by lucylq · Pull Request #10985 · pytorch/executorch

lucylq · 2025-05-19T22:28:01Z

Stack from ghstack (oldest at bottom):

Differential Revision: D75027794

…n kernel_deps Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

pytorch-bot · 2025-05-19T22:28:04Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10985

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 46 Unrelated Failures

As of commit 55e0507 with merge base 9663bfb ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
The process '/usr/bin/git' failed with exit code 128
Build Presets / apple (macos-arm64) / build (gh)
The process '/opt/homebrew/bin/git' failed with exit code 1
Build Presets / linux (pybind, linux.2xlarge, executorch-ubuntu-22.04-clang12) / build (gh)
Build Presets / linux (pybind, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11-aarch64) / build (gh)
The process '/usr/bin/git' failed with exit code 1
Check Labels / Check labels (gh)
RuntimeError: Error checking labels: PR does not have required labels
Lint / lintrunner / linux-job (gh)
The process '/usr/bin/git' failed with exit code 1
pull / android / build-llm-demo / linux-job (gh)
The process '/usr/bin/git' failed with exit code 1
pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 6ebdeac6665881027244fd121a559472d33a110575c094a0783f258fc4003dce /exec failed with exit code 139

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-binary-size-linux-gcc / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-eval_llama-wikitext-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-llama_runner_eager-linux / linux-job (gh) (detected as infra flaky with no runner)
pull / test-llama-runner-linux (bf16, custom, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (detected as infra flaky with no runner)
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.arm64.2xlarge, executorch-ubuntu-22.04-gc... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu-22.04-... / linux-job (gh) (detected as infra flaky with no runner)
pull / test-llama-runner-linux-android / linux-job (gh) (detected as infra flaky with no runner)
pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh) (detected as infra flaky with no runner)
pull / test-mediatek-models-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (add_mul, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no runner)
pull / test-models-linux (add, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (add, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux (emformer_join, xnnpack-quantization-delegation, linux.4xlarge.memory) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux (emformer_transcribe, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no runner)
pull / test-models-linux (ic3, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (ic4, portable, linux.4xlarge.memory) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux (linear, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux (linear, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no runner)
pull / test-models-linux (mobilebert, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (mobilebert, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (phi_4_mini, portable, linux.4xlarge.memory) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (resnet18, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (resnet50, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux (w2l, portable, linux.4xlarge.memory) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux-basic (mv3, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, cmake, linux.2xlarge, executorch-u... / linux-job (gh) (detected as infra flaky with no runner)
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, cmake, linux.arm64.2xlarge, execut... / linux-job (gh) (detected as infra flaky with no runner)
pull / test-models-linux-basic (vit, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / test-models-linux-basic (vit, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux-basic (vit, portable, cmake, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, cmake, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-moshi-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-phi-3-mini-runner-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-pybind-build-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-qnn-models-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-quantized-aot-lib-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-setup-linux-gcc / linux-job (gh) (detected as infra flaky with no runner)
pull / unittest / linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / unittest-arm-backend-with-no-fvp (test_pytest_models) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1
pull / unittest-buck / linux / linux-job (gh) (detected as infra flaky with no runner)
pull / unittest-editable / linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…n kernel_deps Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) ghstack-source-id: 284959143 Pull Request resolved: #10985

facebook-github-bot · 2025-05-19T22:28:11Z

This pull request was exported from Phabricator. Differential Revision: D75027794

github-actions · 2025-05-19T22:28:40Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…n kernel_deps #10985 Try to make user error harder for dtype selective build Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

…n kernel_deps #10985 Try to make user error harder for dtype selective build Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) ghstack-source-id: 284970179 Pull Request resolved: #10988

…n kernel_deps #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

…n kernel_deps #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) ghstack-source-id: 284982140 Pull Request resolved: #10990

…if portable/optimized not in kernel_deps" #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

…mized not in kernel_deps" #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

Pull Request resolved: #10990 #10985 Try to make user error harder for dtype selective build. Currently, if dtype selective build cannot be enabled we silently fallback to regular dtype selective build. This diff: 1. Emits failure when there is nothing in kernel_deps and dtype_selective_build=True. 2. Remove dtype_selective_build=True for cases in (1). 3. Warning that dtype selective build is not enabled if user is not in xplat. ghstack-source-id: 285196226 Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/)

…if portable/optimized not in kernel_deps" #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

…mized not in kernel_deps" #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

…n kernel_deps (#11020) Pull Request resolved: #10990 #10985 Try to make user error harder for dtype selective build. Currently, if dtype selective build cannot be enabled we silently fallback to regular dtype selective build. This diff: 1. Emits failure when there is nothing in kernel_deps and dtype_selective_build=True. 2. Remove dtype_selective_build=True for cases in (1). 3. Warning that dtype selective build is not enabled if user is not in xplat. ghstack-source-id: 285201952 Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/)

Dtype selective build: fail if not xplat, if portable/optimized not i…

55e0507

…n kernel_deps Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]

This was referenced May 19, 2025

Move optimized target definitions to op_registration.bzl #10877

Merged

Dtype selective build for optimized ops #10878

Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2025

lucylq mentioned this pull request May 19, 2025

Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps #10988

Closed

lucylq mentioned this pull request May 19, 2025

Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps #10990

Merged

larryliu0820 approved these changes May 20, 2025

View reviewed changes

lucylq closed this May 20, 2025

lucylq had a problem deploying to cherry-pick-bot May 20, 2025 22:44 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps#10985

Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps#10985
lucylq wants to merge 1 commit intogh/lucylq/77/basefrom
gh/lucylq/77/head

lucylq commented May 19, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented May 19, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lucylq commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10985

❌ 8 New Failures, 46 Unrelated Failures

Uh oh!

facebook-github-bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

This PR needs a release notes: label

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucylq commented May 19, 2025 •

edited

Loading

pytorch-bot bot commented May 19, 2025 •

edited

Loading

This PR needs a `release notes:` label