Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps#10990
Merged
facebook-github-bot merged 3 commits intogh/lucylq/79/basefrom May 20, 2025
Merged
Conversation
…n kernel_deps #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10990
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit afd78fc with merge base d50f26f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
May 19, 2025
…n kernel_deps #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) ghstack-source-id: 284982140 Pull Request resolved: #10990
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75027794 |
…mized not in kernel_deps" #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 20, 2025
Pull Request resolved: #10990 #10985 Try to make user error harder for dtype selective build. Currently, if dtype selective build cannot be enabled we silently fallback to regular dtype selective build. This diff: 1. Emits failure when there is nothing in kernel_deps and dtype_selective_build=True. 2. Remove dtype_selective_build=True for cases in (1). 3. Warning that dtype selective build is not enabled if user is not in xplat. ghstack-source-id: 285196226 Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75027794 |
…mized not in kernel_deps" #10985 Try to make user error harder for dtype selective build. Emit warning for now, as too many failures when set to failure :( For example: ``` buck2 build //xplat/sgr/resources/tests/handwriting:pkg buck2 build fbsource//xplat/sgr/resources/mwa:main_pkg_libAndroid Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75027794 |
larryliu0820
approved these changes
May 20, 2025
facebook-github-bot
merged commit e789002
into
gh/lucylq/79/base
88 of 91 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
May 21, 2025
…n kernel_deps (#11020) Pull Request resolved: #10990 #10985 Try to make user error harder for dtype selective build. Currently, if dtype selective build cannot be enabled we silently fallback to regular dtype selective build. This diff: 1. Emits failure when there is nothing in kernel_deps and dtype_selective_build=True. 2. Remove dtype_selective_build=True for cases in (1). 3. Warning that dtype selective build is not enabled if user is not in xplat. ghstack-source-id: 285201952 Differential Revision: [D75027794](https://our.internmc.facebook.com/intern/diff/D75027794/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
#10985
Try to make user error harder for dtype selective build.
Emit warning for now, as too many failures when set to failure :(
For example: