Conversation
.github/workflows/pull.yml
Outdated
| uses: pytorch/test-infra/.github/workflows/linux_job.yml@main | ||
| with: | ||
| runner: linux.2xlarge | ||
| docker-image: executorch-ubuntu-22.04-clang12 |
There was a problem hiding this comment.
You would need to use the new ARM image here once it's ready
There was a problem hiding this comment.
Yes! Please let me know when it's ready. So far I use the main image just for debugging
There was a problem hiding this comment.
@huydhn ETA when it will be ready? @digantdesai if Arm really want to enable it asap, we can enable it by installing the their simulator and toolchains on the fly like this.
.github/workflows/trunk.yml
Outdated
| uses: pytorch/test-infra/.github/workflows/linux_job.yml@main | ||
| with: | ||
| runner: linux.2xlarge | ||
| docker-image: executorch-ubuntu-22.04-clang12 |
There was a problem hiding this comment.
Same comment about using the new ARM image
This reverts commit 181fa12.
.github/workflows/pull.yml
Outdated
| with: | ||
| docker-image: executorch-ubuntu-22.04-clang12 | ||
|
|
||
| test-arm-backend-delegation: |
There was a problem hiding this comment.
Are we running this on PRs? I think we should run all vendor-specific jobs ins trunk but with the ability to run it on PRs with labeling.
There was a problem hiding this comment.
Yes. I will remove this part. It's testing only.
guangy10
left a comment
There was a problem hiding this comment.
Thanks Hansong and Huy for helping on this
.ci/docker/build.sh
Outdated
|
|
||
| case "${IMAGE_NAME}" in | ||
| executorch-ubuntu-22.04-clang12) | ||
| ARM_SDK=yes |
There was a problem hiding this comment.
Will remove this line in the end
| cp ../../requirements-lintrunner.txt ./ | ||
|
|
||
| # Copy arm setup script from root to here | ||
| cp -r ../../examples/arm/ ./arm |
There was a problem hiding this comment.
BTW how do we trigger an image build if examples/arm changes?
There was a problem hiding this comment.
we only should need setup.sh and patches FWIW. But your question is valid.
There was a problem hiding this comment.
It's harder to copy the specific files than the entire dir :p
.github/workflows/trunk.yml
Outdated
| uses: pytorch/test-infra/.github/workflows/linux_job.yml@main | ||
| with: | ||
| runner: linux.2xlarge | ||
| docker-image: executorch-ubuntu-22.04-clang12-arm-sdk |
There was a problem hiding this comment.
The name here should be executorch-ubuntu-22.04-arm-sdk I think. Once you set the correct name, the failed jobs here https://github.com/pytorch/executorch/actions/runs/6712861373/job/18243312911 should use the correct Docker image
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign merged this pull request in 2535a25. |
Add the setup part to docker image to make the run faster.