NXP backend: Add docker image for nxp backend tests#11473
NXP backend: Add docker image for nxp backend tests#11473robert-kalmar wants to merge 2 commits intopytorch:mainfrom
Conversation
Fix duplicate bpe tokenizer base symbol (pytorch#63)
| executorch-ubuntu-22.04-arm-sdk, | ||
| executorch-ubuntu-22.04-qnn-sdk, | ||
| executorch-ubuntu-22.04-mediatek-sdk, | ||
| executorch-ubuntu-22.04-nxp-sdk, |
There was a problem hiding this comment.
We don't have anything special to install in the docker image right? If yes, I guess we can continue to use the base image? What are your thoughts?
@cccclai - what was the rationale for suggesting a new docker image?
There was a problem hiding this comment.
No, we don't. At least not at this moment.
Looking at the docker file nobody (arm, qnn, mediatek) really does https://github.com/pytorch/executorch/blob/79e53ebd00d07bef28975b1a089ce87a074c9ab7/.ci/docker/ubuntu/Dockerfile .
Although Arm in early day installed the Arm SDK on docker-image https://github.com/pytorch/executorch/pull/1111/files#diff-f271c3ed0c135590409465f4ad55c570c418d2c0509bbf1b1352ebdd1e6611d1
+1 for the rationale @cccclai
|
Note, this PR fails with (https://github.com/pytorch/executorch/actions/runs/15534181661/job/43729414408?pr=11473#step:7:26128): and what I understood from the conversation, when Arm was introducing its docker image (#1111). Someone from you should create the registry for the executorch/executorch-ubuntu-22.04-nxp-sdk images. Correct? |
Yeah @huydhn is the PoC to register. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
2 similar comments
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary
NXP backend: Add docker image for nxp backend tests
Test plan
N/A
cc @digantdesai @JakeStevens