Define ET_HAS_EXCEPTIONS macro#11603
Merged
facebook-github-bot merged 2 commits intogh/swolchok/456/basefrom Jun 14, 2025
Merged
Define ET_HAS_EXCEPTIONS macro#11603facebook-github-bot merged 2 commits intogh/swolchok/456/basefrom
facebook-github-bot merged 2 commits intogh/swolchok/456/basefrom
Conversation
To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11603
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f713d4b with merge base d660bde ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76470039 |
JacobSzwejbka
approved these changes
Jun 13, 2025
|
|
||
| #ifdef __EXCEPTIONS | ||
| #define ET_HAS_EXCEPTIONS 1 | ||
| #elif defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS |
Contributor
There was a problem hiding this comment.
just curious where do __EXCEPTIONS and _HAS_EXCEPTIONS come from?
Contributor
There was a problem hiding this comment.
Oh its in the test plan internally. From the compilers.
swolchok
added
the
release notes: api
To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76470039 |
facebook-github-bot
merged commit 051cb78
into
gh/swolchok/456/base
94 of 97 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Jun 14, 2025
Pull Request resolved: #11603 To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. ghstack-source-id: 290334875 @exported-using-ghexport Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/)
swolchok
added a commit
that referenced
this pull request
Jun 16, 2025
Pull Request resolved: #11603 To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. ghstack-source-id: 290334875 @exported-using-ghexport Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/)
swolchok
added a commit
that referenced
this pull request
Jun 16, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11603 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/456/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <swolchok@meta.com>
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Jun 17, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11603 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/456/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <swolchok@meta.com>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#11603 To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. ghstack-source-id: 290334875 @exported-using-ghexport Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled.
Differential Revision: D76470039