Conversation
pytorchbot
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11664
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added
the
release notes: api
swolchok
left a comment
swolchok
left a comment
There was a problem hiding this comment.
merging mergebot pr after I make sure lintrunner failure isn't real
|
cannot find an actual error message in lintrunner output. checked out PR and |
swolchok
force-pushed
the
gh/swolchok/456/orig
branch
from
ba40863 to
8aa7e8b
Compare
|
cannot repro lintrunner failure, merging to get the branch in sync |
|
oh, lintrunner is required |
Pull Request resolved: #11603 To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. ghstack-source-id: 290334875 @exported-using-ghexport Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/)
swolchok
force-pushed
the
gh/swolchok/456/orig
branch
from
8aa7e8b to
9f82ef7
Compare
|
CI green except for lintrunner. rebasing to see if that failure (lintrunner init) goes away. |
lintrunner init is failing on main. landing based on previous green-except-lintrunner run. |
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11603 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/456/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <swolchok@meta.com>
3 participants
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11603 by @swolchok
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/456/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/orig
@diff-train-skip-merge