Skip to content

Fix shadowing error in mmap_data_loader.cpp#11858

Merged
GregoryComer merged 1 commit intopytorch:mainfrom
GregoryComer:fix-shadow
Jun 23, 2025
Merged

Fix shadowing error in mmap_data_loader.cpp#11858
GregoryComer merged 1 commit intopytorch:mainfrom
GregoryComer:fix-shadow

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jun 23, 2025

Summary

Fix a -Wshadow error causing internal build failures. I will add this to the GitHub CI, as well.

Test plan

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11858

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 70 Pending

As of commit 01066b4 with merge base 18e4240 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2025
@github-actions
Copy link

github-actions bot commented Jun 23, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer GregoryComer merged commit da36d8a into pytorch:main Jun 23, 2025
95 checks passed
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Jun 24, 2025
@GregoryComer
Revert "Fix shadowing error in mmap_data_loader.cpp (pytorch#11858)"
55e9bce 
This reverts commit da36d8a.
@GregoryComer GregoryComer mentioned this pull request Jun 24, 2025
Merged
GregoryComer added a commit that referenced this pull request Jun 24, 2025
@GregoryComer
Revert mmap loader changes (#11928)
d5fe5fa 
### Summary
Revert #11654 and
#11858 due to Meta-internal
build breakage. I will re-land these (preserving attribution).
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@GregoryComer @hinriksnaer
Fix shadowing error in mmap_data_loader.cpp (pytorch#11858)
422e2ee 
### Summary
Fix a -Wshadow error causing internal build failures. I will add this to
the GitHub CI, as well.

### Test plan
CI
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@GregoryComer @hinriksnaer
Revert mmap loader changes (pytorch#11928)
6b314e5 
### Summary
Revert pytorch#11654 and
pytorch#11858 due to Meta-internal
build breakage. I will re-land these (preserving attribution).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GregoryComer @JacobSzwejbka @facebook-github-bot