Skip to content

Revert mmap loader changes#11928

Merged
GregoryComer merged 2 commits intopytorch:mainfrom
GregoryComer:revert-mmap-loader-changes
Jun 24, 2025
Merged

Revert mmap loader changes#11928
GregoryComer merged 2 commits intopytorch:mainfrom
GregoryComer:revert-mmap-loader-changes

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jun 24, 2025

Summary

Revert #11654 and #11858 due to Meta-internal build breakage. I will re-land these (preserving attribution).

@pytorch-bot pytorch-bot bot added the ci-no-td label Jun 24, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11928

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 45 Pending

As of commit a285663 with merge base 752f6a7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
@github-actions
Copy link

github-actions bot commented Jun 24, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer GregoryComer merged commit d5fe5fa into pytorch:main Jun 24, 2025
93 of 97 checks passed
@GregoryComer GregoryComer mentioned this pull request Jun 24, 2025
Merged
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@GregoryComer @hinriksnaer
Revert mmap loader changes (pytorch#11928)
6b314e5 
### Summary
Revert pytorch#11654 and
pytorch#11858 due to Meta-internal
build breakage. I will re-land these (preserving attribution).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GregoryComer @JacobSzwejbka @facebook-github-bot