Skip to content

[ET-VK][ez] Fix unused variable#15058

Closed
SS-JIA wants to merge 1 commit intomainfrom
pr15058
Closed

[ET-VK][ez] Fix unused variable#15058
SS-JIA wants to merge 1 commit intomainfrom
pr15058

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Oct 13, 2025

Summary:
Title says it all. Also add -Werror=unused-variable to compile flags when building Vulkan to guard against this in the future.

@SS-JIA
[ET-VK][ez] Fix unused variable
ae1ee50 
Summary:
Title says it all. Also add `-Werror=unused-variable` to compile flags when building Vulkan to guard against this in the future.
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15058

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 4 Unrelated Failures

As of commit ae1ee50 with merge base 9560800 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka JacobSzwejbka mentioned this pull request Oct 13, 2025
Merged
JacobSzwejbka added a commit that referenced this pull request Oct 13, 2025
@JacobSzwejbka
Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and… (
b18243b 
#15066)

… Clamp/Clamp (#14415)"

This reverts commit a5d7e5c.

Broke internal builds @SS-JIA is trying to fix this in
#15058 will leave relanding to
him

### Summary
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests)
for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes
#<issue-id>` line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be
the upcoming release notes, please add a "Release notes: <area>" label.
For a list of available release notes labels, check out
[CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).

### Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual
commands you used and note down tests that you have written if
applicable.
@github-actions
Copy link

github-actions bot commented Dec 13, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Dec 13, 2025
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
@JacobSzwejbka @jirioc
Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and… (
42d8522 
pytorch#15066)

… Clamp/Clamp (pytorch#14415)"

This reverts commit a5d7e5c.

Broke internal builds @SS-JIA is trying to fix this in
pytorch#15058 will leave relanding to
him

### Summary
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests)
for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes
#<issue-id>` line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be
the upcoming release notes, please add a "Release notes: <area>" label.
For a list of available release notes labels, check out
[CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).

### Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual
commands you used and note down tests that you have written if
applicable.
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@SS-JIA SS-JIA closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SS-JIA @JacobSzwejbka