Skip to content

Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and…#15066

Merged
JacobSzwejbka merged 2 commits intomainfrom
revert-vulkan-change
Oct 13, 2025
Merged

Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and…#15066
JacobSzwejbka merged 2 commits intomainfrom
revert-vulkan-change

Conversation

@JacobSzwejbka
Copy link
Contributor

… Clamp/Clamp (#14415)"

This reverts commit a5d7e5c.

Broke internal builds @SS-JIA is trying to fix this in #15058 will leave relanding to him

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15066

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 57 Pending, 1 Unrelated Failure

As of commit f185cf5 with merge base 8876113 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka
Copy link
Contributor Author

JacobSzwejbka commented Oct 13, 2025

@GregoryComer The original PR thats being reverted here got cherrypicked to 1.0 @SS-JIA tells me it should be fine if main and 1.0 diverge as no further vulkan picks are planned, but wanted to let you know the plan

@JacobSzwejbka JacobSzwejbka merged commit b18243b into main Oct 13, 2025
117 of 124 checks passed
@JacobSzwejbka JacobSzwejbka deleted the revert-vulkan-change branch October 13, 2025 20:32
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
pytorch#15066)

… Clamp/Clamp (pytorch#14415)"

This reverts commit a5d7e5c.

Broke internal builds @SS-JIA is trying to fix this in
pytorch#15058 will leave relanding to
him

### Summary
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests)
for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes
#<issue-id>` line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be
the upcoming release notes, please add a "Release notes: <area>" label.
For a list of available release notes labels, check out
[CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).

### Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual
commands you used and note down tests that you have written if
applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants