Skip to content

min pip version#3526

Closed
lucylq wants to merge 1 commit intomainfrom
lfq.min-pip-version
Closed

min pip version#3526
lucylq wants to merge 1 commit intomainfrom
lfq.min-pip-version

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented May 7, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented May 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3526

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 39169b9 with merge base 8e2e2e2 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 7, 2024

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lucylq lucylq marked this pull request as ready for review May 7, 2024 00:52
@lucylq lucylq requested a review from dbort May 7, 2024 00:52
facebook-github-bot pushed a commit that referenced this pull request May 9, 2024
@lucylq @facebook-github-bot
min pip version (#3526)
65c3ebd 
Summary:
see [T188128067](https://www.internalfb.com/intern/tasks/?t=188128067)


Differential Revision: D57032452

Pulled By: lucylq
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2024

This pull request was exported from Phabricator. Differential Revision: D57032452

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2024

This pull request was exported from Phabricator. Differential Revision: D57032452

lucylq added a commit that referenced this pull request May 9, 2024
@lucylq @facebook-github-bot
min pip version (#3526)
198b81d 
Summary:
see [T188128067](https://www.internalfb.com/intern/tasks/?t=188128067)

Pull Request resolved: #3526

Differential Revision: D57032452

Pulled By: lucylq
@lucylq lucylq force-pushed the lfq.min-pip-version branch from 65c3ebd to 198b81d Compare May 9, 2024 18:20
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2024

This pull request was exported from Phabricator. Differential Revision: D57032452

lucylq added a commit that referenced this pull request May 9, 2024
@lucylq @facebook-github-bot
min pip version (#3526)
26f6792 
Summary:
see [T188128067](https://www.internalfb.com/intern/tasks/?t=188128067)

Pull Request resolved: #3526

Differential Revision: D57032452

Pulled By: lucylq
@lucylq lucylq force-pushed the lfq.min-pip-version branch from 198b81d to 26f6792 Compare May 9, 2024 18:26
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2024

This pull request was exported from Phabricator. Differential Revision: D57032452

lucylq added a commit that referenced this pull request May 9, 2024
@lucylq @facebook-github-bot
min pip version (#3526)
b0b2864 
Summary:
see [T188128067](https://www.internalfb.com/intern/tasks/?t=188128067)

Pull Request resolved: #3526

Differential Revision: D57032452

Pulled By: lucylq
@lucylq lucylq force-pushed the lfq.min-pip-version branch from 26f6792 to b0b2864 Compare May 9, 2024 20:08
@lucylq lucylq requested a review from huydhn May 9, 2024 20:21
huydhn
huydhn reviewed May 9, 2024
View reviewed changes
.github/workflows/build-wheels-linux.yml Outdated
post-script: build/packaging/post_build_script.sh
smoke-test-script: build/packaging/smoke_test.py
package-name: executorch
python-version: '3.10'
Copy link
Contributor

@huydhn huydhn May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning pip version is fine but I don't think python-version is a legit input parameter here. The workflow is failing https://github.com/pytorch/executorch/actions/runs/9022911297

The list of supported inputs can be found here https://github.com/pytorch/test-infra/blob/main/.github/workflows/build_wheels_linux.yml#L6-L77

Copy link
Contributor

@huydhn huydhn May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a task in my queue to add support for this though, so that different repos could specify which python versions they want instead of strictly following PyTorch build matrix, which covers all 3.8 to 3.12 atm

huydhn
huydhn reviewed May 9, 2024
View reviewed changes
build/packaging/pre_build_script.sh
readonly BUILD_DEPS=(
# This list must match the build-system.requires list from pyproject.toml.
"cmake"
"pip>=23"
Copy link
Contributor

@huydhn huydhn May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you couldn't set this for older python versions, I wonder if this syntax works:

pip>=23 ; python_version >= "3.10"

https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L220-L221

Building ET with older python version is expected to fail atm IIRC

Copy link
Contributor Author

@lucylq lucylq May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmn, seems like we can't use this syntax with setuptools. Can we disable the test for older python version? Or, it's part of a larger test that runs through all of them, so we can't?

facebook-github-bot pushed a commit that referenced this pull request May 10, 2024
@lucylq @facebook-github-bot
min pip version (#3526)
77b25b0 
Summary:
see [T188128067](https://www.internalfb.com/intern/tasks/?t=188128067)
and pytorch/torchchat#726


Differential Revision: D57032452

Pulled By: lucylq
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 10, 2024

This pull request was exported from Phabricator. Differential Revision: D57032452

@huydhn huydhn added the ciflow/binaries/all Release PRs with this label will build wheels for all python versions label May 10, 2024
@huydhn
Copy link
Contributor

huydhn commented May 10, 2024

@pytorchbot rebase

@lucylq @facebook-github-bot
min pip version (#3526)
39169b9 
Summary:
see [T188128067](https://www.internalfb.com/intern/tasks/?t=188128067)
and pytorch/torchchat#726


Differential Revision: D57032452

Pulled By: lucylq
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 10, 2024

This pull request was exported from Phabricator. Differential Revision: D57032452

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 10, 2024

@lucylq merged this pull request in 1871ec1.

@lucylq lucylq mentioned this pull request May 10, 2024
Closed
@lucylq lucylq deleted the lfq.min-pip-version branch January 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@dbort dbort Awaiting requested review from dbort

Assignees

No one assigned

Labels

ciflow/binaries/all Release PRs with this label will build wheels for all python versions CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucylq @facebook-github-bot @huydhn