Skip to content

min pip version #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucylq wants to merge 1 commit into from
Closed

min pip version #3526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/packaging/pre_build_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ set -euxo pipefail
readonly BUILD_DEPS=(
# This list must match the build-system.requires list from pyproject.toml.
"cmake"
"pip>=23"
Copy link
Contributor

@huydhn huydhn May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you couldn't set this for older python versions, I wonder if this syntax works:

pip>=23 ; python_version >= "3.10"

https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L220-L221

Building ET with older python version is expected to fail atm IIRC

Copy link
Contributor Author

@lucylq lucylq May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmn, seems like we can't use this syntax with setuptools. Can we disable the test for older python version? Or, it's part of a larger test that runs through all of them, so we can't?

"pyyaml"
"setuptools>=63"
"tomli"
Expand Down
1 change: 1 addition & 0 deletions install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ EXIR_REQUIREMENTS=(
# pip packages needed for development.
DEVEL_REQUIREMENTS=(
cmake # For building binary targets.
"pip>=23" # For building the pip package.
pyyaml # Imported by the kernel codegen tools.
"setuptools>=63" # For building the pip package.
tomli # Imported by extract_sources.py when using python < 3.11.
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[build-system]
requires = [
"cmake", # For building binary targets in the wheel.
"pip>=23", # For building the pip package.
"pyyaml", # Imported by the kernel codegen tools.
"setuptools>=63", # For building the pip package contents.
"tomli", # Imported by extract_sources.py when using python < 3.11.
Expand Down