Added HiFi optimizations for add sub mul and div operators#5483
Closed
cad-audio wants to merge 16 commits intopytorch:mainfrom
Closed
Added HiFi optimizations for add sub mul and div operators#5483cad-audio wants to merge 16 commits intopytorch:mainfrom
cad-audio wants to merge 16 commits intopytorch:mainfrom
Conversation
* Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Add nnlib as submodule * Adding nnlib submodule * Integrated nnlib API unde backends/cadence/hifi * Fix review comments on PR#3 * Incorporated feedback from Meta team. * lint errors fixed * Adding Sub operator optimized version * Add optimization for add, mul operators * Adding Div operator * Modified div mod to cover truncate and floor modes --------- Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com> Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>
Adding add sub mul and div optimizations
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5483
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e9d9f6c with merge base 324f021 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
hsharma35
reviewed
Sep 19, 2024
Contributor
|
LGTM other than some minor refactorings! |
Adding sigmoid and tanh optimizations
Fixing review comments in 5483
Namespace update as per review comments
Adding cflags to prevent compilation halts
|
Mergebot is not configured for this repository. Please use the merge button provided by GitHub. |
Contributor
|
@cad-audio seems like there are linting errors (https://github.com/pytorch/executorch/actions/runs/11379328098/job/31679034373?pr=5483). After those are fixed, should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added HiFi optimizations for add sub mul and div operators