Skip to content

Updating cadence ops with new name space, rebasing 6 optimized ops#6407

Merged
mcremon-meta merged 17 commits intopytorch:mainfrom
cad-audio:dijopaul_dev
Oct 22, 2024
Merged

Updating cadence ops with new name space, rebasing 6 optimized ops#6407
mcremon-meta merged 17 commits intopytorch:mainfrom
cad-audio:dijopaul_dev

Conversation

@dijopaul
Copy link
Contributor

@dijopaul dijopaul commented Oct 21, 2024

dijopaul and others added 17 commits September 19, 2024 12:20
@dijopaul @cad-audio
Main backup (#12)
4ed8bd6 
* Add nnlib as submodule

* Adding nnlib submodule

* Integrated nnlib API unde backends/cadence/hifi

* Fix review comments on PR#3

* Add nnlib as submodule

* Adding nnlib submodule

* Integrated nnlib API unde backends/cadence/hifi

* Fix review comments on PR#3

* Incorporated feedback from Meta team.

* lint errors fixed

* Adding Sub operator optimized version

* Add optimization for add, mul operators

* Adding Div operator

* Modified div mod to cover truncate and floor modes

---------

Co-authored-by: cad-audio <86048415+cad-audio@users.noreply.github.com>
Co-authored-by: cad-audio <cad_audio_tflm@cadence.com>
@cad-audio
Merge pull request #7 from dijopaul/main
71d78a1 
Adding add sub mul and div optimizations
@dijopaul
Adding sigmoid optimizations
6ad490a
@dijopaul
Adding tanh optimizations
c0b1005
@cad-audio
Merge pull request #8 from dijopaul/main
41d7533 
Adding sigmoid and tanh optimizations
@dijopaul
Fixing review comments in 5483
a8c4f66
@dijopaul
Adding cflags to prevent compilation halts
99a772c
@cad-audio
Merge pull request #9 from dijopaul/main
8064895 
Fixing review comments in 5483
@dijopaul
Adding cflags to prevent compilation halts
9543622
@dijopaul
Changing name space of optimized ops; Remove unused ops from file
d45e25d
@dijopaul
Merge branch 'main' of https://github.com/dijopaul/executorch
a3581f1
@cad-audio
Merge pull request #11 from dijopaul/main
fd955cf 
Namespace update as per review comments
@cad-audio
Merge pull request #10 from dijopaul/main_cflags
5851fca 
Adding cflags to prevent compilation halts
@cad-audio
Merge branch 'main' into main
605f374
@cad-audio
fixed lint issues.
4e89e2a
@cad-audio
Merge branch 'main' into main
e9d9f6c
@dijopaul
Namespace updates for cadence ops, adding 6 optimized ops
a1340f7
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6407

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1340f7 with merge base 324f021 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
mcremon-meta
mcremon-meta approved these changes Oct 22, 2024
View reviewed changes
backends/cadence/aot/functions_hifi.yaml
kernels:
- arg_meta: null
kernel_name: torch::executor::add_out
kernel_name: impl::HiFi::add_out
Copy link
Contributor

@mcremon-meta mcremon-meta Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should be cadence::impl::HiFi too, but we can do that in a follow up if this can be merged

Copy link
Contributor Author

@dijopaul dijopaul Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a new PR for this

Copy link
Contributor Author

@dijopaul dijopaul Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6433

@mcremon-meta mcremon-meta merged commit 979708d into pytorch:main Oct 22, 2024
@dijopaul dijopaul mentioned this pull request Oct 22, 2024
Merged
kirklandsign added a commit that referenced this pull request Oct 24, 2024
@kirklandsign
Revert "Updating cadence ops with new name space, rebasing 6 optimize…
f9238e3 
…d ops (#6407)"

This reverts commit 979708d.

Broke internal tests
@kirklandsign kirklandsign mentioned this pull request Oct 24, 2024
Merged
kirklandsign added a commit that referenced this pull request Oct 24, 2024
@kirklandsign
Revert "Updating cadence ops with new name space, rebasing 6 optimize… (
ec15487 
#6482)

Revert "Updating cadence ops with new name space, rebasing 6 optimized ops (#6407)"

This reverts commit 979708d.

Broke internal tests
@kirklandsign
Copy link
Contributor

kirklandsign commented Oct 24, 2024

Hi @dijopaul sorry I reverted this because it seems to break our internal CI. Maybe we need to import to internal repo first and run CI there

@kirklandsign
Copy link
Contributor

kirklandsign commented Oct 24, 2024

xplat/executorch/backends/cadence/hifi/operators/op_tanh.cpp:10:10: fatal error: 'executorch/kernels/portable/cpu/pattern/pattern.h' file not found
#include <executorch/kernels/portable/cpu/pattern/pattern.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@kirklandsign
Copy link
Contributor

kirklandsign commented Oct 24, 2024

@mcremon-meta need to update BUCK

@zonglinpeng
Copy link
Contributor

zonglinpeng commented Oct 24, 2024

@kirklandsign #6477 the fix is landing internally. thanks for the heads up. cc. @mcremon-meta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcremon-meta mcremon-meta mcremon-meta approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dijopaul @kirklandsign @zonglinpeng @mcremon-meta @facebook-github-bot @cad-audio