Fix build gating on optimized_portable_kernels#9825
Closed
swolchok wants to merge 1 commit intogh/swolchok/379/headfrom
Closed
Fix build gating on optimized_portable_kernels#9825swolchok wants to merge 1 commit intogh/swolchok/379/headfrom
swolchok wants to merge 1 commit intogh/swolchok/379/headfrom
Conversation
Contributor
Author
swolchok
requested review from
GregoryComer,
JacobSzwejbka,
cccclai,
iseeyuan,
jackzhxng,
kirklandsign,
larryliu0820,
lucylq,
manuelcandales,
shoumikhin and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9825
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7f2bbdb with merge base 5fcb6b8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
requested review from
Gasoonjia,
SS-JIA,
digantdesai,
kimishpatel,
mcr229 and
mergennachin
as code owners
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 2, 2025
Merged
Contributor
|
some 7k lines of change on this one too |
This was referenced Apr 2, 2025
Contributor
Author
thanks, reran ghstack. idk why it does this but we can bug @ezyang about it when he's back |
This was referenced Apr 2, 2025
Contributor
Author
|
duplicate PR |
This was referenced Apr 14, 2025
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
If we don't need optimized kernels, we don't need optimized portable kernels. ghstack-source-id: 84cef23 ghstack-comment-id: 2755985472 Pull-Request-resolved: pytorch/executorch#9665 ghstack-source-id: 84cef23 ghstack-comment-id: 2771179663 Pull Request resolved: pytorch/executorch#9825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't need optimized kernels, we don't need optimized portable kernels.
Pull-Request-resolved: #9665