Migrate elementwise_util callers to the variants with out_dtypes in template arguments#9828
Closed
swolchok wants to merge 1 commit intogh/swolchok/383/headfrom
Closed
Migrate elementwise_util callers to the variants with out_dtypes in template arguments#9828swolchok wants to merge 1 commit intogh/swolchok/383/headfrom
swolchok wants to merge 1 commit intogh/swolchok/383/headfrom
Conversation
Contributor
Author
swolchok
requested review from
Gasoonjia,
GregoryComer,
JacobSzwejbka,
SS-JIA,
cccclai,
digantdesai,
iseeyuan,
jackzhxng,
kirklandsign,
larryliu0820,
lucylq,
manuelcandales,
mcr229,
mergennachin,
shoumikhin and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9828
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit a756254 with merge base 5fcb6b8 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 2, 2025
Merged
facebook-github-bot
added
the
CLA Signed
Contributor
|
something seems wrong here, there is like 7k lines in this pr |
This was referenced Apr 2, 2025
Contributor
Author
|
duplicate PR |
This was referenced Apr 14, 2025
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
…emplate arguments This is necessary to take advantage of the previous PR #9388, which creates dtype-specialized implementations for the non-mixed dtype case. The size cost of this approach looking at `__TEXT` of size_test_all_optimized_ops built with bash test/build_optimized_size_test.sh is 104212 bytes, a 2.2% increase. ghstack-source-id: ec4f1fe ghstack-comment-id: 2761913142 Pull-Request-resolved: pytorch/executorch#9741 ghstack-source-id: ec4f1fe ghstack-comment-id: 2771182674 Pull Request resolved: pytorch/executorch#9828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to take advantage of the previous PR #9388, which creates dtype-specialized implementations for the non-mixed dtype case.
The size cost of this approach looking at
__TEXTof size_test_all_optimized_ops built with bash test/build_optimized_size_test.sh is 104212 bytes, a 2.2% increase.Pull-Request-resolved: #9741