Open
Conversation
…lient.Grpc 22.0.0 Include Newtonsoft upgrade Include .Net6.0 Upgrade to solution and project (upgraded using auto upgrade tool)
Pull Request Review Checklist:
|
jbradford
requested changes
Nov 9, 2022
Member
jbradford
left a comment
jbradford
left a comment
There was a problem hiding this comment.
A question on this, not sure if was discussed elsewhere.
| /// <returns>EventStoreClient.</returns> | ||
| public static EventStoreClient GetEventStoreClient(string connectionString) | ||
| { | ||
| var settings = EventStoreClientSettings.Create(connectionString); |
Member
There was a problem hiding this comment.
Is this definitely all we need to specify compared to the old version? Seems like previously we were setting a gossipTimeout, is that not something we still need to support or is there a different way of setting it now?
Member
There was a problem hiding this comment.
Discussed with @jbradford and @JamesMcCaig in Teams. Neither of us have been able to find references to this in the documentation, which suggests that the approach that we have taken here is sufficient
jbradford
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade from .netStandard 2.0 to .Net6
Change EventStoreEventTools to use new methods in the GRPC EventStore Client
Include Newtonsoft newest Version
Change EventStoreConnectionbuilder to EventStoreClientBuilder
Include a EventStoreClient GetEventStoreClient function which returns a EventStoreClient given a connectionstring
Include new Test functions for ToEventData