-
Notifications
You must be signed in to change notification settings - Fork 0
SBT-9849 EventStore.Client.Grpc.Streams #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JamesMcCaig
wants to merge
1
commit into
master
Choose a base branch
from
SBT-9849-Update-Tools-EventStore-22-Client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
src/EventStoreEventTools.Tests/EventStoreEventTools.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <IsPackable>false</IsPackable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="EventStore.Client.Grpc" Version="22.0.0" /> | ||
| <PackageReference Include="EventStore.Client.Grpc.Streams" Version="22.0.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0-preview-20221003-04" /> | ||
| <PackageReference Include="NUnit" Version="3.13.3" /> | ||
| <PackageReference Include="NUnit3TestAdapter" Version="4.3.0" /> | ||
| <PackageReference Include="NUnit.Analyzers" Version="3.5.0"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="coverlet.collector" Version="3.2.0"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Tools.EventStore\Tools.EventStore.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
37 changes: 37 additions & 0 deletions
37
src/EventStoreEventTools.Tests/EventStoreEventToolsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| namespace EventStoreEventTools.Tests | ||
| { | ||
| using NUnit.Framework; | ||
| using EventStore.Client; | ||
| using CorshamScience.Tools.EventStore; | ||
| using Newtonsoft.Json; | ||
| using System.Text; | ||
|
|
||
| internal class EventStoreEventToolsTests | ||
| { | ||
| [Test] | ||
| public void ToEventData_Given_Valid_Event_Returns_EventData() | ||
| { | ||
| var standardEvent = new StandardEvent | ||
| { | ||
| Id = Uuid.NewUuid(), | ||
| Description = "Test", | ||
| }; | ||
|
|
||
| var data = Encoding.UTF8.GetBytes(JsonConvert.SerializeObject(standardEvent)); | ||
| var eventHeaders = new { ClrType = standardEvent.GetType().AssemblyQualifiedName }; | ||
|
|
||
| var metadata = Encoding.UTF8.GetBytes(JsonConvert.SerializeObject(eventHeaders)); | ||
| var typeName = standardEvent.GetType().Name; | ||
|
|
||
| var expectedObject = new EventData(standardEvent.Id, typeName, data, metadata); | ||
|
|
||
| var toEventData = EventStoreEventTools.ToEventData(standardEvent.Id, standardEvent); | ||
| Assert.That(JsonConvert.SerializeObject(toEventData), Is.EqualTo(JsonConvert.SerializeObject(expectedObject))); | ||
| } | ||
| private class StandardEvent | ||
| { | ||
| public Uuid Id { get; set; } | ||
| public string? Description { get; set; } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // <copyright file="EventStoreClientBuilder.cs" company="Corsham Science"> | ||
| // Copyright (c) Corsham Science. All rights reserved. | ||
| // </copyright> | ||
|
|
||
| namespace CorshamScience.Tools.EventStore | ||
| { | ||
| using System; | ||
| using global::EventStore.Client; | ||
|
|
||
| /// <summary> | ||
| /// A helper class for quickly building an <see cref="EventStoreClient"/>. | ||
| /// </summary> | ||
| public static class EventStoreClientBuilder | ||
| { | ||
| /// <summary> | ||
| /// Builds an <see cref="EventStoreClient"/> using the default settings. | ||
| /// </summary> | ||
| /// <param name="connectionString">Put valid connection string.</param> | ||
| /// <returns>EventStoreClient.</returns> | ||
| public static EventStoreClient GetEventStoreClient(string connectionString) | ||
| { | ||
| var settings = EventStoreClientSettings.Create(connectionString); | ||
| return new EventStoreClient(settings); | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this definitely all we need to specify compared to the old version? Seems like previously we were setting a gossipTimeout, is that not something we still need to support or is there a different way of setting it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @jbradford and @JamesMcCaig in Teams. Neither of us have been able to find references to this in the documentation, which suggests that the approach that we have taken here is sufficient