CB Bug fix for Qwen3VL Dense and basic cleaning of example script and Model File#926
Open
qcdipankar wants to merge 2 commits intomainfrom
Open
CB Bug fix for Qwen3VL Dense and basic cleaning of example script and Model File#926qcdipankar wants to merge 2 commits intomainfrom
qcdipankar wants to merge 2 commits intomainfrom
Conversation
Contributor
|
@qcdipankar please include the test for full_batch_size ≥ 2 with multiple images |
qcdipankar
force-pushed
the
cb_fix_qwen3vl_mainline
branch
from
b051a47 to
f092377
Compare
mohiso22
approved these changes
Apr 24, 2026
… model file Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
…den state implementation for qwen3vlmoe Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
qcdipankar
force-pushed
the
cb_fix_qwen3vl_mainline
branch
from
7e2ef2e to
856eb3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When running CB with single image multiple time with different prompts it was working whereas with multiple images and prompts it was failing.
Resolution: The hidden states calculation was done with index [0] every time as a result when the broadcasting was happening with batch size 4 it was taking the first image only and we were getting wrong output in CB. Taking full hidden_states ensures the error does not occur.