Skip to content

CB Bug fix for Qwen3VL Dense and basic cleaning of example script and Model File #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qcdipankar wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −25
Open

CB Bug fix for Qwen3VL Dense and basic cleaning of example script and Model File #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9765e64
CB Bug fix for Qwen3VL Dense and basic cleaning of example script and…
qcdipankar Apr 20, 2026
856eb3b
Added test for multi images for qwenvl and qwenvlmoe also changed hid…
qcdipankar Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions QEfficient/transformers/models/qwen3_vl/modeling_qwen3_vl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,7 @@ def forward(
key_states = self.k_norm(self.k_proj(hidden_states).view(hidden_shape)).transpose(1, 2)
value_states = self.v_proj(hidden_states).view(hidden_shape).transpose(1, 2)

# cos, sin = position_embeddings
# kv_seq_len = key_states.shape[-2]
# kv_seq_len = past_key_value.get_seq_length()
past_seen_tokens = past_key_values.get_seq_length(self.layer_idx) if past_key_values is not None else 0
# cos, sin = self.rotary_emb(value_states, seq_len=kv_seq_len)

query_states, key_states = qeff_apply_rotary_pos_emb(query_states, key_states, cos_cached, sin_cached)
blocking_config = getattr(self, "attn_blocking_config", AttentionBlockingConfig())
Expand Down Expand Up @@ -502,7 +498,7 @@ def forward(
residual = hidden_states
hidden_states = self.post_attention_layernorm(hidden_states)
hidden_states = self.mlp(hidden_states)
hidden_states = residual + hidden_states[0]
hidden_states = residual + hidden_states

outputs = (hidden_states,)

Expand Down Expand Up @@ -669,7 +665,7 @@ class QEffQwen3VLDecoderWrapper(nn.Module):
def __init__(self, model):
super().__init__()
self.model = model
self.language_model = self.model.model
self.language_model = self.model.model.language_model

def get_submodules_for_export(self) -> Type[nn.Module]:
"""
Expand Down
4 changes: 3 additions & 1 deletion QEfficient/transformers/models/qwen3_vl_moe/modeling_qwen3_vl_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,9 @@ def forward(
residual = hidden_states
hidden_states = self.post_attention_layernorm(hidden_states)
hidden_states = self.mlp(hidden_states)
hidden_states = residual + hidden_states[0]
if isinstance(hidden_states, tuple):
hidden_states, _ = hidden_states
hidden_states = residual + hidden_states

outputs = (hidden_states,)

Expand Down
15 changes: 0 additions & 15 deletions examples/image_text_to_text/models/qwen3vl/qwen3_vl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@
num_devices=4,
height=354,
width=536,
# height=1024,
# width=1024,
mxfp6_matmul=True,
mxint8_kv_cache=True,
aic_enable_depth_first=True,
Expand All @@ -95,9 +93,6 @@

### IMAGE + TEXT ###
image_url = "https://picsum.photos/id/237/536/354"
# image_url = (
# "https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/datasets/cat_style_layout.png"
# )

image = Image.open(requests.get(image_url, stream=True).raw)

Expand All @@ -111,16 +106,6 @@
},
]

# messages_2 = [
# {
# "role": "user",
# "content": [
# {"type": "image", "image": image},
# {"type": "text", "text": "Describe about the color of the dog."},
# ],
# },
# ]

messages = [messages_1] * batch_size

texts = [processor.apply_chat_template(msg, tokenize=False, add_generation_prompt=True) for msg in messages]
Expand Down
6 changes: 3 additions & 3 deletions tests/configs/image_text_model_configs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
"num_layers": 1,
"img_url_list":[
"https://picsum.photos/id/237/536/354",
"https://picsum.photos/id/237/536/354"
"https://picsum.photos/id/238/536/354"
],
"text_prompt_list": [
"Can you describe the image in detail?",
Expand Down Expand Up @@ -235,7 +235,7 @@
"num_layers": 1,
"img_url_list":[
"https://picsum.photos/id/237/536/354",
"https://picsum.photos/id/237/536/354"
"https://picsum.photos/id/238/536/354"
],
"text_prompt_list": [
"Can you describe the image in detail?",
Expand Down Expand Up @@ -292,7 +292,7 @@
"num_layers": 1,
"img_url_list":[
"https://picsum.photos/id/237/536/354",
"https://picsum.photos/id/237/536/354"
"https://picsum.photos/id/238/536/354"
],
"text_prompt_list": [
"Can you describe the image in detail.",
Expand Down
Loading