Conversation
| withr::local_envvar(RSTUDIO = NA, .local_envir = .env) | ||
| withr::local_envvar( | ||
| RSTUDIO = NA, | ||
| LANGUAGE = "en", |
There was a problem hiding this comment.
Should we include a sentence about this in the list of things local_test_context() sets, up about line 44?
Btw. that line also needs a fix for RSTUDIO, which is now unset.
|
IINM it will work on Unix, but probably (?) not on Windows (though I do see a ✅ for the Windows GHA). We had some headaches getting non-English tests to work on Windows... see Rdatatable/data.table#4524. I'm not sure if it's any easier a problem to specifically force English than it was for us to temporarily set Chinese. For reference I think you're referring to this from WRE 1.3.1:
There's also this in R administration 2.8 about testing R installation: And I think our troubles were related to this note in R administration 7.2:
|
|
I also have a vague recollection that the translation is cached, so that after an error message has been processed once, changing |
|
Running the testthat revdeps now, just to double check that this won't accidentally break anything. |
|
I individually checked the four failures — they seem unrelated to the language setting. |
@MichaelChirico does this seem ok to you? (Since you're the only person I know who's testing translations). R CMD check already sets the language to English so we don't think this should affect much existing code.
Fixes #1213