Merged
Conversation
tapped out more TODO updated Deps (we can move Mojo::JWT::Google out now) updated repo to point to ours began a major refactor cleaning up cruft from Client::Discovery now and testing it more sanely now, too began cleaning up examples (oh goodness gracious) started sprinkling my own TODOs Client::Discover - added 403 error handling, and don't bother using header otherwise refactored the cache to be its own function removed a few stupid tests made some test tools for NON-stupid testing basically, beginning major league refactor
removed (as far as I know) our currently deprecated methods
almost done with Client::Discovery!
started fixing brace style in client-userAgent
…veesh/WebService-GoogleAPI-Client into rabbiveesh/service_account
- including POD
- better reflects that its a reader for a particular file type
- allows for easier custom backends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for service accounts, and fixes some outstanding bugs from the
previous version (including the ridiculous arrayref token bug).
In addition, reworks the architecture to be nicer, IMO. And start fixing up the
brace style.
Clean up the test suite, also to be more sane.