Support Service Accounts

.gitignore

@@ -28,3 +28,7 @@ examples/*.png
 **/delme*
 *.json
 docs/cover/*
+
+.yath.user.rc
+.*.sw?
+.perl-version

.perltidyrc

@@ -1,16 +1,17 @@
--pbp -nst    # Start with Perl Best Practices - not sure how to drive and cuddles my braces
--w       # Show all warnings
--iob     # Ignore old breakpoints
--l=180    # 80 characters per line
--mbl=2   # No more than 2 blank lines
--i=2     # Indentation is 2 columns
--ci=2    # Continuation indentation is 2 columns
--vt=0    # vertical tightness
--pt=0    # parenthesis tightness
--bt=0    # brace tightness
--sbt=2   # square bracket tightness
--wn      # Weld nested containers
--isbc    # Don't indent comments without leading space
--sbl     # sub-brace on new line
--bl      # Opening Braces Left
--b -bext='/' # operwrite the file and delete backup if no errors
+--warning-output
+--ignore-old-breakpoints
+--maximum-line-length=80 
+--maximum-consecutive-blank-lines=2
+--indent-columns=2
+--continuation-indentation=2
+--vertical-tightness=0
+--paren-tightness=2
+--brace-tightness=1
+--square-bracket-tightness=2
+--weld-nested-containers
+--indent-spaced-block-comments
+--cuddled-else
+--trim-qw
+--opening-brace-always-on-right
+--opening-token-right
+-b       # overwrite the file

CONTRIBUTING.md

@@ -1,6 +1,24 @@
+# When hacking on this repo
+
+There are some live tests in `xt/` which require real user credentials. All they
+do is create a file in Google Drive, and then delete it, in order to make sure that 
+things are ACTUALLY running.
+
+If you don't trust me, then please don't run those tests. They're part of the
+release process, so I'll just run them before releasing.
+
+If you DO trust me (and I'm flattered), then you need to set the
+`GAPI_XT_USER_CREDS` environment variable to a string containing the gapi.json
+file, followed by `:` followed by the user to user. Like this:
+
+    /absolute/path/to/gapi.json:your_email@gmail.com
+
+And also set the `GAPI_XT_SERVICE_CREDS` to the service account file downloaded
+from Google.
+
 # Bug Reporting and General Help Requests
 
-- Use the [Github Issues Page](https://github.com/pscott-au/WebService-GoogleAPI-Client/issues) 
+- Use the [Github Issues Page](https://github.com/rabbiveesh/WebService-GoogleAPI-Client/issues) 
 
 ## Github Repo Management
 
@@ -10,8 +28,6 @@
 
 # CONTRIBUTING CODE
 
-- Use perlcritic and perltidy if my bracer style is offensive
-- This is my first module using dzilla to package a module - I'm not completely sold on it and may be using it incorrectly - advice on improving usage welcome
 - There remain a few architectural bad smells from the original source code this was based on - don't assume that the class structure is sane
 - Pull reqeusts preferred but whatever works for you I will try to work with
 
@@ -21,11 +37,11 @@
 - refactor to improve test coverage
 - clean up the test structure
 - survey other Google Perl modules
-- explore handling of batch requests
+- implement batch requests - really an interface question more than the
+  technicalities
 - API worked examples with help functions
 - ability to examine CHI cache and introspect on Client instance metrics ( number of HTTP calls, cache size, TTL data sent/received etc )
 - comparison with other language Client libraries
-- The structure under the AuthStorage is ugly and needs some love
 
 
 Github Repo: [https://github.com/pscott-au/WebService-GoogleAPI-Client]

Changes

@@ -0,0 +1,14 @@
+{{$NEXT}}
+
+ENHANCEMENTS
+- add support for service accounts
+- rework storage backend to allow custom implementations (here's looking at you, redis)
+- allow introspection for credentials on $res returned from an api query
+
+BREAKING CHANGES
+- will immediately on non-existent API endpoints
+- rework AuthStorage classes: anything that depended on
+  ::AuthStorage or ::Credentials in an undocumented way will likely explode.
+  Please open an issue on github and I'll try and help you migrate
+- remove some undocumented options
+- the examples/ dir MAY be broken, I didn't check (they need cleaning up anyways)

README.md

@@ -97,7 +97,7 @@ I was unable to get the [Dist::Zilla](https://metacpan.org/pod/Dist::Zilla) pack
     my $gapi = WebService::GoogleAPI::Client->new(debug => 0);
 
     ## This idiom selects the first authorised user from gapi.json 
-    my $aref_token_emails = $gapi->auth_storage->storage->get_token_emails_from_storage;
+    my $aref_token_emails = $gapi->auth_storage->get_token_emails_from_storage;
     my $user = $aref_token_emails->[0];
     print "Running tests with default user email = $user\n";
     $gapi->user($user);
@@ -222,7 +222,7 @@ See the examples folder for specific access examples.
 - API Discovery with local caching using [CHI](https://metacpan.org/pod/CHI) File
 - OAUTH app credentials (client\_id, client\_secret, users access\_token && refresh\_token) storage stored in local gapi.json file
 - Automatic access\_token refresh (if user has refresh\_token) and saving refreshed token to storage
-- CLI tool ([go_auth](https://metacpan.org/pod/distribution/WebService-GoogleAPI-Client/bin/goauth)) with lightweight HTTP server to simplify config OAuth2 configuration, sccoping, authorization and obtaining access\_ and refresh\_ tokens
+- CLI tool ([goauth](https://metacpan.org/pod/distribution/WebService-GoogleAPI-Client/bin/goauth)) with lightweight HTTP server to simplify config OAuth2 configuration, sccoping, authorization and obtaining access\_ and refresh\_ tokens
 
 
 # SEE ALSO