This repository was archived by the owner on Apr 7, 2026. It is now read-only.
Secrets as Env Variables Design doc#62
Merged
rynowak merged 8 commits intoradius-project:mainfrom Aug 27, 2024
Merged
Conversation
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
nicolejms
reviewed
Aug 19, 2024
rynowak
reviewed
Aug 19, 2024
ytimocin
reviewed
Aug 19, 2024
kachawla
reviewed
Aug 19, 2024
lakshmimsft
reviewed
Aug 19, 2024
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
ytimocin
reviewed
Aug 26, 2024
ytimocin
previously approved these changes
Aug 26, 2024
ytimocin
dismissed
their stale review
I meant to add comments but approved. I will approve once the doc is complete.
rynowak
reviewed
Aug 26, 2024
willtsai
reviewed
Aug 26, 2024
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
This was referenced Aug 27, 2024
rynowak
approved these changes
Aug 27, 2024
Contributor
|
Thanks @superbeeny !!! |
Reshrahim
pushed a commit
to Reshrahim/design-notes
that referenced
this pull request
Sep 20, 2024
Initial PR for design doc in support of radius-project/radius#7744 addressing radius-project/radius#5520 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR for design doc in support of radius-project/radius#7744 addressing radius-project/radius#5520