Adding Kubernetes native secrets to secret stores#7744
Adding Kubernetes native secrets to secret stores#7744rynowak merged 3 commits intoradius-project:mainfrom
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7744 +/- ##
==========================================
+ Coverage 61.06% 61.18% +0.11%
==========================================
Files 523 523
Lines 27497 27588 +91
==========================================
+ Hits 16792 16879 +87
- Misses 9218 9222 +4
Partials 1487 1487 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
5f240b8 to
910fdde
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
Thanks for submitting this @superbeeny ! This is a substantial feature that has been on the backlog for a long time. I'll start reviewing the code. While we're making progress on that, a few month things we'll need to do.
/cc @Reshrahim as FYI |
ytimocin
left a comment
There was a problem hiding this comment.
This is looking great! Added some comments and asked some questions. Thanks a lot!
|
DCO not my fault ;) |
|
Functional Test - https://github.com/radius-project/radius/actions/runs/9997221043/job/27633433901#step:27:216 failed with a 403 error which I don't think is related to this PR |
e0b647e to
52fb121
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Initial PR for design doc in support of radius-project/radius#7744 addressing radius-project/radius#5520 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
0919594 to
7232cc6
Compare
|
not sure how that happened |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
1d9cbd7 to
4c3613c
Compare
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
4c3613c to
f2ffaa6
Compare
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
kachawla
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments!
Initial PR for design doc in support of radius-project/radius#7744 addressing radius-project/radius#5520 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Description
Adding secret store capabilities to reference kubernetes secrets natively
Type of change
Fixes: #5520