Workflow and playwright test updates by ytimocin · Pull Request #1360 · radius-project/samples

ytimocin · 2024-04-24T17:58:47Z

Added Playwright failure videos.
Removing Wait for all pods to be ready step because the previous step, rad deploy, should do the waiting already.
Making sure we skip certain steps if Cancel Workflow is called.
Adding the name of the EKS Cluster to the Delete EKS Cluster step. (Write EKS cluster name to issue title or description #1003)
Removing rad uninstall from the Delete EKS Cluster step. (EKS cluster not deleted if rad not installed #868)
Updating the dependencies in the playwright package.json file.
Changing to liveness check instead of readiness check. Please see this comment.
Added a logic to reload page if the catalog items are not found. Not sure if this is an eShop problem but sometimes the service that needs to return the products throws an error. Please see this video.

willdavsmith · 2024-04-25T23:56:12Z

+        HealthChecksUI__HealthChecks__9__Uri: 'http://ordering-signalrhub:5112/liveness'
        HealthChecksUI__HealthChecks__10__Name: 'Ordering HTTP Background Check'
-        HealthChecksUI__HealthChecks__10__Uri: 'http://ordering-backgroundtasks:5111/hc'
+        HealthChecksUI__HealthChecks__10__Uri: 'http://ordering-backgroundtasks:5111/liveness'


were we using the health check incorrectly before?

The eshop code has a readiness check at /hc and a liveness check at /liveness. We had the readiness check hooked up as a liveness check

willdavsmith · 2024-04-25T23:57:22Z

+        run: |
+          if [[ "${{ matrix.container }}" != "" ]]; then
+            rad resource expose containers ${{ matrix.container }} ${{ matrix.exposeArgs }} --port ${{ matrix.port }} &
+            export ENDPOINT="http://localhost:3000/"


Suggested change

export ENDPOINT="http://localhost:3000/"

export ENDPOINT="http://localhost:${{ matrix.port }}"

rynowak · 2024-04-26T02:15:28Z

      - edge
  schedule: # Run every 2 hours
    - cron: "0 */2 * * *"
+concurrency:


Can you add a comment explaining why this is needed? It's easy to forget the rationale for adding something like this later.

This is to group workflow runs and cancel if a new workflow starts running. What I mean is that, if we create a PR, a workflow is triggered. Then if we push another commit to that PR, another workflow will be triggered and the in-progress one should be cancelled.

Now that I think about this, because we might have already created resources, I think it would be good to not cancel this workflow and make sure that the resources are deleted if created.

What do you think @rynowak?

rynowak · 2024-04-26T02:16:41Z

        if: steps.gen-id.outputs.RUN_TEST == 'true'
        id: deploy-app
-        run: rad deploy ${{ matrix.path }} ${{ matrix.deployArgs }} -e ${{ matrix.env }}
-      - name: Wait for all pods to be ready


Do we no longer care about waiting for the pods to be ready?

I think we discussed this in one of our 1:1 meeting. rad deploy should wait for all pods to be ready before returning successfully. Is that wrong?

rynowak · 2024-04-26T02:32:42Z

Is this working better now that you swapped the health checks?

ytimocin · 2024-04-26T06:00:21Z

Is this working better now that you swapped the health checks?

Yes, it definitely is working better. Not passing the tests all the time but still a good improvement so far with the changes here.

Signed-off-by: ytimocin <ytimocin@microsoft.com>

willdavsmith · 2024-04-29T20:02:51Z

  # Empty the file
  truncate -s 0 $DELETED_RESOURCES_FILE

-  for resource_type in ${RESOURCE_TYPES//,/ }


why the changes to this file?

just a reformat

Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>

* update gh to ado sync workflow to use service principals (#1363) * Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <ytimocin@microsoft.com> * Triggering workflow Signed-off-by: ytimocin <ytimocin@microsoft.com> --------- Signed-off-by: ytimocin <ytimocin@microsoft.com> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <ytimocin@microsoft.com> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <ytimocin@microsoft.com> --------- Signed-off-by: ytimocin <ytimocin@microsoft.com> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <ytimocin@microsoft.com> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> --------- Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com> Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> Signed-off-by: Will <28876888+willtsai@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: Yetkin Timocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Workflow and playwright test updates (#1360) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Changing the place of page.reload in the tests (#1492) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Adding a job that will purge AWS EKS clusters every 6 hours (#1462) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update all deps of all apps (#1536) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Updating the runner of purge azure test resources workflow (#1537) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update purget test resources to fix the workflow failures (#1552) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Fixing the eShop catalog load issue for the UI tests (#1548) Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> --------- Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com> Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> Signed-off-by: Will <28876888+willtsai@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> Co-authored-by: Will <28876888+willtsai@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: Yetkin Timocin <ytimocin@microsoft.com>

ytimocin force-pushed the ytimocin/wtUpdates branch 9 times, most recently from 2cd9ac3 to 30d7f76 Compare April 25, 2024 23:06

ytimocin changed the base branch from edge to v0.33 April 25, 2024 23:06

ytimocin mentioned this pull request Apr 25, 2024

Error: Waiting for deployment "webshoppingagg" rollout to finish: 0 of 1 updated replicas are available... #1057

Closed

willdavsmith reviewed Apr 25, 2024

View reviewed changes

ytimocin force-pushed the ytimocin/wtUpdates branch 3 times, most recently from 090f61b to 2f36308 Compare April 26, 2024 01:05

rynowak reviewed Apr 26, 2024

View reviewed changes

ytimocin force-pushed the ytimocin/wtUpdates branch from 2f36308 to 891c135 Compare April 26, 2024 05:51

ytimocin force-pushed the ytimocin/wtUpdates branch 2 times, most recently from 8c34b1a to 6e808c4 Compare April 26, 2024 15:43

ytimocin requested review from rynowak and willdavsmith April 26, 2024 20:42

ytimocin force-pushed the ytimocin/wtUpdates branch from 6e808c4 to 3c3b66c Compare April 26, 2024 21:36

Workflow and playwright test updates

cbeaf5e

Signed-off-by: ytimocin <ytimocin@microsoft.com>

ytimocin force-pushed the ytimocin/wtUpdates branch from 3c3b66c to cbeaf5e Compare April 27, 2024 02:39

willdavsmith approved these changes Apr 29, 2024

View reviewed changes

ytimocin merged commit 2c0de3a into v0.33 Apr 29, 2024

ytimocin deleted the ytimocin/wtUpdates branch April 29, 2024 20:19

This was referenced Apr 29, 2024

Write EKS cluster name to issue title or description #1003

Closed

EKS cluster not deleted if rad not installed #868

Closed

Fix sample failures with name resolution error #1030

Closed

sk593 pushed a commit that referenced this pull request May 23, 2024

Workflow and playwright test updates (#1360)

6473285

Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 pushed a commit that referenced this pull request May 23, 2024

Workflow and playwright test updates (#1360)

4bcb8c3

Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workflow and playwright test updates#1360

Workflow and playwright test updates#1360
ytimocin merged 1 commit into
v0.33from
ytimocin/wtUpdates

ytimocin commented Apr 24, 2024 •

edited

Loading

Uh oh!

willdavsmith Apr 25, 2024

Uh oh!

rynowak Apr 26, 2024

Uh oh!

willdavsmith Apr 25, 2024

Uh oh!

rynowak Apr 26, 2024

Uh oh!

ytimocin Apr 26, 2024

Uh oh!

ytimocin Apr 26, 2024

Uh oh!

rynowak Apr 26, 2024

Uh oh!

ytimocin Apr 26, 2024

Uh oh!

rynowak commented Apr 26, 2024

Uh oh!

ytimocin commented Apr 26, 2024

Uh oh!

willdavsmith Apr 29, 2024

Uh oh!

ytimocin Apr 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	export ENDPOINT="http://localhost:3000/"
	export ENDPOINT="http://localhost:${{ matrix.port }}"

Conversation

ytimocin commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rynowak commented Apr 26, 2024

Uh oh!

ytimocin commented Apr 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ytimocin commented Apr 24, 2024 •

edited

Loading