Remove AWS CLI install from AWS workflows#1967
Merged
Merged
Conversation
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
This was referenced Dec 30, 2024
rynowak
approved these changes
Dec 31, 2024
This was referenced Jan 2, 2025
kachawla
approved these changes
Jan 2, 2025
ytimocin
approved these changes
Jan 6, 2025
| name: Purge AWS EKS Clusters | ||
|
|
||
| on: | ||
| workflow_dispatch: |
Contributor
There was a problem hiding this comment.
This is very useful addition. Thanks!
This was referenced Jan 7, 2025
This was referenced Jan 7, 2025
vishwahiremat
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Update samples for v0.41 * Bump cross-spawn from 7.0.3 to 7.0.6 in /samples/demo (#1890) Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add ORAS install to test workflow (#1969) Signed-off-by: willdavsmith <willdavsmith@gmail.com> * Updating playwright version to fix the missing packages issue (#1980) Signed-off-by: ytimocin <ytimocin@microsoft.com> * Updating Dapr UI Sample to dotnet 6 (#1970) Signed-off-by: ytimocin <ytimocin@microsoft.com> * Bump nanoid from 3.3.4 to 3.3.8 in /samples/demo/client (#1896) Dependabot couldn't find the original pull request head commit, 2f3d48c. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump path-to-regexp and express in /samples/demo/client (#1893) Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove AWS CLI install from AWS workflows (#1967) * Remove AWS CLI install Signed-off-by: willdavsmith <willdavsmith@gmail.com> * Add workflow_dispatch to AWS runs Signed-off-by: willdavsmith <willdavsmith@gmail.com> --------- Signed-off-by: willdavsmith <willdavsmith@gmail.com> * Upmerge to edge Signed-off-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: willdavsmith <willdavsmith@gmail.com> Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will Smith <willdavsmith@gmail.com> Co-authored-by: Yetkin Timocin <ytimocin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1966
Not sure why, but
apt-get install awsclihas started failing. Theubuntu-latestrunner images already have the AWS CLI pre-installed so we should just use that install instead of installing it ourselves. We already do this with thePurge RDS DBInstancesworkflow: https://github.com/radius-project/samples/actions/workflows/purge-aws-rds-snapshots.yaml. I also addedworkflow_dispatchtriggers so that we can test this more easily in the future.