Update the dependencies of Dapr sample apps#1970
Conversation
ytimocin
force-pushed
the
ytimocin/dapr/update-deps
branch
9 times, most recently
from
d0e30a9 to
1e57892
Compare
There was a problem hiding this comment.
Just a refactor of the file
| @@ -1,4 +1,4 @@ | |||
| FROM node:8-alpine | |||
| FROM node:22-alpine | |||
There was a problem hiding this comment.
Update to node 22 from 8 (which is very old)
There was a problem hiding this comment.
Updated the dependency (because I happened to be working in this folder)
| WORKDIR /src | ||
|
|
||
| COPY *.csproj . | ||
| RUN dotnet restore -r linux-musl-x64 |
There was a problem hiding this comment.
Removed the linux-musl-x64. I am still learning about Runtime Identifiers and Framework-Dependent Publishing: https://learn.microsoft.com/en-us/dotnet/core/deploying/.
There was a problem hiding this comment.
Is this architecture what was causing the issue?
| FROM mcr.microsoft.com/dotnet/aspnet:8.0-alpine | ||
| WORKDIR /app | ||
|
|
||
| RUN addgroup -S appgroup && adduser -S appuser -G appgroup |
There was a problem hiding this comment.
Added this for extra security.
There was a problem hiding this comment.
I added this but not sure if this project needs it. I will do research on it.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Dapr.Client" Version="1.1.2" /> | ||
| <PackageReference Include="Dapr.Client" Version="1.14.0" /> |
There was a problem hiding this comment.
Updated the Dapr.Client version.
There was a problem hiding this comment.
This got automatically generated.
There was a problem hiding this comment.
What is this used for? If it gets automatically generated but it's not used anywhere do we need to track it in the repo? We could add it to the gitignore otherwise
Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
ytimocin/dapr/update-deps
branch
from
1e57892 to
1ac7b1f
Compare
kachawla
left a comment
kachawla
left a comment
There was a problem hiding this comment.
Just curious - how did we figure out that the issue is related to dependency versions?
To be honest, I am not exactly sure. I built the image locally from the main branch and it wasn't working. There were also no logs in the Pod that gave me a clue. I decided to update the Dapr UI App from dotnet 5 which was too old to dotnet 8. I updated the Dockerfile accordingly. Then when I built an image that image started working fine for me. I think it was also time that we updated the versions for the applications. The Node App for Dapr was using Node 8. I updated it to 22. And, as mentioned, UI App was using dotnet 5. That got updated to dotnet 8. For dependencies, we were using Dapr 1.2.0 which got updated to 1.14.0. |
* Update samples for v0.41 * Bump cross-spawn from 7.0.3 to 7.0.6 in /samples/demo (#1890) Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add ORAS install to test workflow (#1969) Signed-off-by: willdavsmith <willdavsmith@gmail.com> * Updating playwright version to fix the missing packages issue (#1980) Signed-off-by: ytimocin <ytimocin@microsoft.com> * Updating Dapr UI Sample to dotnet 6 (#1970) Signed-off-by: ytimocin <ytimocin@microsoft.com> * Bump nanoid from 3.3.4 to 3.3.8 in /samples/demo/client (#1896) Dependabot couldn't find the original pull request head commit, 2f3d48c. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump path-to-regexp and express in /samples/demo/client (#1893) Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove AWS CLI install from AWS workflows (#1967) * Remove AWS CLI install Signed-off-by: willdavsmith <willdavsmith@gmail.com> * Add workflow_dispatch to AWS runs Signed-off-by: willdavsmith <willdavsmith@gmail.com> --------- Signed-off-by: willdavsmith <willdavsmith@gmail.com> * Upmerge to edge Signed-off-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: willdavsmith <willdavsmith@gmail.com> Signed-off-by: ytimocin <ytimocin@microsoft.com> Signed-off-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will Smith <willdavsmith@gmail.com> Co-authored-by: Yetkin Timocin <ytimocin@microsoft.com>
3 participants
Fixing: #1895
Updating the dependencies of the Dapr sample apps.
dotnet run --project ui.csprojis working locally. Now testing it in the pipeline.