Update Test Samples Workflow - Set up Test EKS Cluster for Dapr#2013
Merged
Conversation
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
kachawla
changed the title
This was referenced Jan 16, 2025
ytimocin
previously approved these changes
Jan 18, 2025
Contributor
ytimocin
left a comment
ytimocin
left a comment
There was a problem hiding this comment.
PRs don't run the tests on AWS. We can merge this in and test it in production.
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
nithyatsu
approved these changes
Jan 23, 2025
kachawla
commented
Jan 24, 2025
| aws eks update-kubeconfig --region ${{ env.AWS_REGION }} --name ${{ steps.gen-id.outputs.TEST_EKS_CLUSTER_NAME }} | ||
| timeout-minutes: 60 | ||
| continue-on-error: false | ||
| - name: Install Dapr |
Member
Author
There was a problem hiding this comment.
Removing this step since Dapr is installed by default with Radius now radius-project/radius#8033
ytimocin
approved these changes
Jan 24, 2025
Contributor
ytimocin
left a comment
ytimocin
left a comment
There was a problem hiding this comment.
Looking good. Let's test it out in production.
Comment on lines
+254
to
+265
| # Fetch the node group name dynamically | ||
| NODEGROUP_NAME=$(eksctl get nodegroup \ | ||
| --cluster ${{ steps.gen-id.outputs.TEST_EKS_CLUSTER_NAME }} \ | ||
| --region ${{ env.AWS_REGION }} \ | ||
| -o json | jq -r '.[0].Name') | ||
|
|
||
| # Fetch the security group ID for the EKS worker nodes | ||
| NODE_SECURITY_GROUP_ID=$(eksctl get nodegroup \ | ||
| --cluster ${{ steps.gen-id.outputs.TEST_EKS_CLUSTER_NAME }} \ | ||
| --name $NODEGROUP_NAME \ | ||
| --region ${{ env.AWS_REGION }} \ | ||
| -o json | jq -r '.[0].Resources.SecurityGroup.ID') |
Contributor
There was a problem hiding this comment.
I think we can consolidate this into a single step using the below command.
aws eks describe-cluster --name <cluster_name> --query 'cluster.resourcesVpcConfig.clusterSecurityGroupId' --region <region>
Member
Author
There was a problem hiding this comment.
Will follow up on this in a separate PR
lakshmimsft
pushed a commit
to lakshmimsft/samples-fork
that referenced
this pull request
Jan 24, 2025
nithyatsu
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Update samples for v0.42 * Update Test Samples Workflow - Set up Test EKS Cluster for Dapr (#2013) * Add check to verify manifests are registered in test workflow (#2031) * Add dependabot file (#2003) * add dependabot file Signed-off-by: sk593 <shruthikumar@microsoft.com> * remove dir Signed-off-by: sk593 <shruthikumar@microsoft.com> * update dir Signed-off-by: sk593 <shruthikumar@microsoft.com> * nit Signed-off-by: sk593 <shruthikumar@microsoft.com> --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> * add check to verify manifests are registered Signed-off-by: lakshmimsft <ljavadekar@microsoft.com> --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> Signed-off-by: lakshmimsft <ljavadekar@microsoft.com> Co-authored-by: Shruthi Kumar <shruthikumar@microsoft.com> * Update command to fetch cluster security group (#2030) Signed-off-by: Karishma Chawla <kachawla@microsoft.com> --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> Signed-off-by: lakshmimsft <ljavadekar@microsoft.com> Signed-off-by: Karishma Chawla <kachawla@microsoft.com> Signed-off-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: Karishma Chawla <kachawla@microsoft.com> Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Co-authored-by: Shruthi Kumar <shruthikumar@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updated Radius installation to always install Dapr, which is causing failures in eshop-aws workflow which runs on EKS cluster, as the cluster is lacking the required prerequisites for Dapr through the approach taken in the Radius CLI.
This is causing consistent sample failures and operational pain during every release.
Fixes: #1901 and radius-project/radius#8141