Skip to content

Fix crash when reopening About or Settings window#46

Merged
dhilgaertner merged 2 commits intomainfrom
feature/crow-42-about-screen-crash
Apr 4, 2026
Merged

Fix crash when reopening About or Settings window#46
dhilgaertner merged 2 commits intomainfrom
feature/crow-42-about-screen-crash

Conversation

@dhilgaertner
Copy link
Copy Markdown
Contributor

Summary

  • Fix app crash when opening the About screen after closing it (also applied to Settings window)
  • Set isReleasedWhenClosed = false on singleton windows so they survive being closed
  • Reuse existing window instance instead of recreating on each open

Closes #42

Test plan

  • Open About screen, close it, reopen it — no crash
  • Repeat open/close cycle 5+ times
  • Same test for Settings window
  • Verify window content displays correctly after reopen

🤖 Generated with Claude Code

dhilgaertner and others added 2 commits April 3, 2026 23:38
NSWindow defaults to isReleasedWhenClosed=true, which deallocates the
window when closed. The stored reference then points to a released
object, causing a crash on the next open. Set isReleasedWhenClosed=false
and reuse the existing window instance instead of recreating it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dhilgaertner dhilgaertner merged commit 12410dd into main Apr 4, 2026
@dhilgaertner dhilgaertner deleted the feature/crow-42-about-screen-crash branch April 4, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crashes when reopening the About screen

1 participant