Skip to content

Fix crash when reopening About or Settings window #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhilgaertner merged 2 commits into from
Apr 4, 2026
Merged

Fix crash when reopening About or Settings window #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d83cdc0
Fix crash when reopening About or Settings window (#42)
dhilgaertner Apr 4, 2026
214a56b
Merge branch 'main' into feature/crow-42-about-screen-crash
dhilgaertner Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/Crow/App/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
}

@objc private func showAbout() {
if let existing = aboutWindow, existing.isVisible {
if let existing = aboutWindow {
existing.makeKeyAndOrderFront(nil)
return
}
Expand All @@ -274,6 +274,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
)
win.title = "About Crow"
win.appearance = NSAppearance(named: .darkAqua)
win.isReleasedWhenClosed = false
win.contentView = hostingView
win.center()
win.makeKeyAndOrderFront(nil)
Expand All @@ -283,7 +284,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
@objc private func showSettings() {
guard let devRoot, let appConfig else { return }

if let existing = settingsWindow, existing.isVisible {
if let existing = settingsWindow {
existing.makeKeyAndOrderFront(nil)
return
}
Expand All @@ -309,6 +310,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
)
win.title = "Settings"
win.appearance = NSAppearance(named: .darkAqua)
win.isReleasedWhenClosed = false
win.contentView = hostingView
win.center()
win.makeKeyAndOrderFront(nil)
Expand Down