Make sure that proxies have checks for all `assert()` and `require()` in TokenNetworkRegistry

[pirapira]

This is a part of #4763.

[pirapira]

The TokenNetworkRegistry version to go through is this: https://github.com/raiden-network/raiden-contracts/blob/7c1f1da47ae1b02c00f6388bb7be341c3fed3160/raiden_contracts/data/source/raiden/TokenNetworkRegistry.sol

[pirapira]

Does the client ever call the constructor of TokenNetworkRegistry? Asked https://ethereum.stackexchange.com/questions/74800/does-the-raiden-client-ever-deploy-tokennetworkregistry.

[pirapira]

createERC20TokenNetwork() has a modifier canCreateTokenNetwork.

https://github.com/raiden-network/raiden-contracts/blob/7c1f1da47ae1b02c00f6388bb7be341c3fed3160/raiden_contracts/data/source/raiden/TokenNetworkRegistry.sol#L76

Is this accounted in the proxy? No #4795

[pirapira]

Suspended till I understand the norm. #4828

[pirapira]

Also stuck on #4829

[pirapira]

Also stuck on #4830

[pirapira]

createERC20TokenNetwork() calls the constructor of TokenNetwork. The constructor has

• a check that the token address is not zero TokenNetworkRegistry proxy should check that token_address is nonzero #4875
• a check that the secret registry address is not zero TokenNetworkRegistry's add_token() should check if secret_registry_address is zero #4882
• a check that the deprecation executor address is not zero TokenNetworkRegistry should check the deprecation executor address before/after sending a tx #4884
• a check that the chain_id is not zero TokenNetworkRegistry should check chain_id before calling createERC20TokenNetwork() #4886
• a check that the settlement_timeout_min is not zero TokenNetworkRegistry proxy should check settlement_timeout_min is not zero #4888
• a check that the settlement_timeout_max is more than the settlement_timeout_min TokenNetworkRegistry proxy should check settlement_timeout_max is bigger than settlement_timeout_min #4889
  • why cannot they be equal? Why can't settlement_timeout_{min,max} cannot be equal? raiden-contracts#1225
• token address has nonempty code
• secret registry address has nonempty code
• channel_participant_deposit_limit is not zero
• token_network_deposit_limit is not zero
• token_network_deposit_limit is at least channel_participant_deposit_limit
• token.total_supply is not zero