Switch to Synapse >= 1.0#4646
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4646 +/- ##
===========================================
- Coverage 80.71% 80.68% -0.04%
===========================================
Files 120 120
Lines 14597 14605 +8
Branches 2262 2263 +1
===========================================
+ Hits 11782 11784 +2
- Misses 2151 2158 +7
+ Partials 664 663 -1
Continue to review full report at Codecov.
|
|
@ulope I think this PR is the right place to remove the cache hack https://github.com/raiden-network/raiden/pull/4665/files#diff-1d37e48f9ceff6d8030570cd36286a61R183 we introduced. |
(Not mergable currently because of raiden-network#4634. Temporarily uses the base64 solution mentioned in the issue.) This updates our testing dependency to matrix-synapse 1.2.1. The Synapse config files generated by the integration tests have been updated to align with new / changed options. Additionally this no longer uses local TLS certificates speeding up tests. Fixes: raiden-network#3387 Required for: raiden-network#4292
ulope
force-pushed
the
feature/synapse-1.x
branch
from
4633a64 to
acfb515
Compare
| recovered = recover( | ||
| data=user.user_id.encode(), signature=Signature(decode_hex(displayname)) | ||
| ) | ||
| if DISPLAY_NAME_HEX_RE.match(displayname): |
There was a problem hiding this comment.
Is this new if check covered by any unit test?
There was a problem hiding this comment.
Yes, invalid signatures are already being tested for. This is just an optimization to skip ecrecover on obviously invalid values.
LefterisJP
left a comment
LefterisJP
left a comment
There was a problem hiding this comment.
Anyway this looks good to me
3 participants
(Not mergable currently because of #4634. Temporarily uses the base64 solution mentioned in the issue.)
This updates our testing dependency to matrix-synapse 1.2.1.
The Synapse config files generated by the integration tests have been updated to align with new / changed options.
Additionally this no longer uses local TLS certificates speeding up tests.
Fixes: #3387
Required for: #4292
Blocked by: #4634