Raiden contracts 0.31.0#4665
Merged
pirapira merged 5 commits intoAug 30, 2019
Merged
Conversation
pirapira
force-pushed
the
raiden-contracts-0.31.0
branch
9 times, most recently
from
9e32ccb to
ad311b5
Compare
pirapira
force-pushed
the
raiden-contracts-0.31.0
branch
from
ad311b5 to
3ce9d6c
Compare
Contributor
Author
|
I've been struggling with raiden-network/scenario-player#230 (comment) (pinning many versions). But maybe it's easier to wait for #4646 |
Codecov Report
@@ Coverage Diff @@
## develop #4665 +/- ##
===========================================
- Coverage 81.05% 80.89% -0.17%
===========================================
Files 118 118
Lines 14226 14222 -4
Branches 2194 2193 -1
===========================================
- Hits 11531 11505 -26
- Misses 2052 2073 +21
- Partials 643 644 +1
Continue to review full report at Codecov.
|
palango
reviewed
Aug 29, 2019
| . ${VENV_PATH}/bin/activate | ||
| pip config set global.progress_bar off | ||
| pip install -U 'pip<19.0.0' wheel pip-tools | ||
| pip install -U 'pip==18.1' 'setuptools==40.8.0' 'wheel==0.33.6' 'pip-tools<3.9.0' |
Contributor
There was a problem hiding this comment.
Are these constraints still necessary with the cache change?
Contributor
Author
There was a problem hiding this comment.
Probably not all of them. I'll try removing some of them (it's rather quick because the problem happens only a few minutes into the CI build.).
because the CI passes this way. After this commit the line is the same as before this PR.
pirapira
force-pushed
the
raiden-contracts-0.31.0
branch
from
5991619 to
7a10d2f
Compare
Contributor
Author
|
Will do. Thanks. |
Contributor
Author
|
Done #4646 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades
raiden-contractsdependency. It also contains some workarounds for raiden-network/scenario-player#230 (comment).PR review check list
Quality check list that cannot be automatically verified.