Fix #353 - Add settings option for password length. #354
Merged
bennothommo merged 8 commits intorainlab:masterfrom Jun 19, 2019
Merged
Fix #353 - Add settings option for password length. #354bennothommo merged 8 commits intorainlab:masterfrom
bennothommo merged 8 commits intorainlab:masterfrom
Conversation
Contributor
obuchmann
commented
Sep 21, 2018
obuchmann
commented
- Add settings option for password length.
- Use password length for password validation and password generation.
…rd length for password validation and password generation.
LukeTowers
reviewed
Sep 21, 2018
Closed
added 2 commits
June 16, 2019 11:41
Also did some code cleanup and fixed an issue with the English lang file changes belonging to the wrong key.
Contributor
|
@obuchmann I have just done some minor code cleanup and renamed EDIT: I have also implemented some of @tobias-kuendig's changes from #375 in order to cover some other areas your original PR didn't cover, such as the Reset Password form. |
added 3 commits
June 16, 2019 12:35
LukeTowers
reviewed
Jun 16, 2019
Contributor
|
I just did a test run of these changes. Everything is working as expected 👍 Great work @obuchmann and @bennothommo ! |
LukeTowers
reviewed
Jun 17, 2019
LukeTowers
reviewed
Jun 17, 2019
Contributor
|
Done @LukeTowers. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.