Reuse model password validation in components#375
Closed
tobias-kuendig wants to merge 6 commits intorainlab:masterfrom
Closed
Reuse model password validation in components#375tobias-kuendig wants to merge 6 commits intorainlab:masterfrom
tobias-kuendig wants to merge 6 commits intorainlab:masterfrom
Conversation
Closed
Contributor
|
@tobias-kuendig I have implemented some of your changes into #354, as I feel it would be better for the minimum password length to be a configurable value in the Backend as opposed to requiring people to extend the validation rules via a Plugin. When you have a moment, would you mind giving that PR a test and let us know if that works for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #373
I'm not sure about the version bump. I'd say at least mark it as
!!!since it might need manual changes to written sign up rules if the minimum length changes.