Add a BOTAN_FN_ISA flag for CPU RNG function#5229
Merged
Conversation
randombit
force-pushed
the
jack/cpu-rng-isa
branch
from
07dc75d to
b4156a9
Compare
This seems to be needed for ARMv8.5 RNG support (#5228)
randombit
force-pushed
the
jack/cpu-rng-isa
branch
from
b4156a9 to
4f7784c
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the ISA (Instruction Set Architecture) specification for the processor RNG functionality from module-level declarations to function-level annotations. This change is preparatory work for adding ARMv8.5 RNG support in a future update.
Changes:
- Introduced
BOTAN_FN_ISA_RNGmacro definitions for x86 (rdrand) and PowerPC (power9) architectures - Applied the new macro to the
read_hwrngfunction in processor_rng.cpp - Removed the module-level ISA specification from info.txt in favor of function-level annotations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/utils/isa_extn.h | Added BOTAN_FN_ISA_RNG macro definitions for x86 (rdrand) and PPC (power9) architectures |
| src/lib/rng/processor_rng/processor_rng.cpp | Added include for isa_extn.h and applied BOTAN_FN_ISA_RNG macro to read_hwrng function |
| src/lib/rng/processor_rng/info.txt | Removed the module-level ISA specification section, migrating to function-level annotations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikatammi
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be needed for ARMv8.5 RNG support (#5228)