Fix timers to work in workers too.#106
Merged
Merged
Conversation
Pauan
suggested changes
Jan 18, 2020
Contributor
Pauan
left a comment
Pauan
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay.
I've left a couple comments on some changes I'd like to see.
Pauan
reviewed
Jan 18, 2020
Pauan
approved these changes
Jan 18, 2020
Contributor
Pauan
left a comment
Pauan
left a comment
There was a problem hiding this comment.
Looks great, thanks for your work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been fixed before in a different way by #56.
But was removed again by #103 to solve #96.
I think the solution offered in this PR should solve #96 without breaking the fix provided by #103.
Related: wasm-bindgen/wasm-bindgen#1046.