Skip to content

Enhance recog verify to report an untested parameter as a failure#405

Merged
mkienow-r7 merged 2 commits intorapid7:masterfrom
mkienow-r7:feature/make-missing-parameter-error
Feb 4, 2022
Merged

Enhance recog verify to report an untested parameter as a failure#405
mkienow-r7 merged 2 commits intorapid7:masterfrom
mkienow-r7:feature/make-missing-parameter-error

Conversation

@mkienow-r7
Copy link
Copy Markdown
Contributor

@mkienow-r7 mkienow-r7 commented Jan 28, 2022

Description

Enhances recog_verify to report an untested parameter as a failure instead of a warning.

Motivation and Context

Ensure all fingerprints have examples that fully verify all capture group parameters.

How Has This Been Tested?

  • rake tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@dabdine
Copy link
Copy Markdown
Contributor

dabdine commented Jan 28, 2022

LGTM.

Should we add an aruba test (in veatures/verify.feature + corresponding 'data' dir file) to validate the output as FAIL?

When I added the change to eliminate some of the warnings, I had to also update verify.feature to remove the WARN lines from the ProFTPd test case that would've otherwise failed. In retrospect, I should've separated them out to a separate test case and file in the data dir.

EDIT: Actually, i think you can do this easily by adding another xml element to the tests_with_failures.xml file and the corresponding case in verify.feature.

@mkienow-r7 mkienow-r7 merged commit ca1d8ff into rapid7:master Feb 4, 2022
@mkienow-r7 mkienow-r7 deleted the feature/make-missing-parameter-error branch February 9, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants