Enhance recog verify to report an untested parameter as a failure#405
Merged
mkienow-r7 merged 2 commits intorapid7:masterfrom Feb 4, 2022
Merged
Conversation
Contributor
|
LGTM. Should we add an aruba test (in veatures/verify.feature + corresponding 'data' dir file) to validate the output as FAIL? When I added the change to eliminate some of the warnings, I had to also update verify.feature to remove the WARN lines from the ProFTPd test case that would've otherwise failed. In retrospect, I should've separated them out to a separate test case and file in the data dir. EDIT: Actually, i think you can do this easily by adding another xml element to the tests_with_failures.xml file and the corresponding case in verify.feature. |
3 tasks
tsellers-r7
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances
recog_verifyto report an untested parameter as a failure instead of a warning.Motivation and Context
Ensure all fingerprints have examples that fully verify all capture group parameters.
How Has This Been Tested?
rake testsTypes of changes
Checklist: