Added initial infrastructure for MG C++ testing and a Pagerank MG test using it#1361
Merged
rapids-bot[bot] merged 32 commits intorapidsai:branch-0.18from Feb 10, 2021
Merged
Conversation
…files to include MPI, but also added the start of the MG Pagerank test file (builds, but tests are still incomplete).
… having a problem with shuffle.
…to be .cpp, utility calls sort_and_shuffle_values() but currently having an issue there. Still need to gather results from all GPUs and do comparison to reference.
…erging in changes.
… needs to be installed instead.
rlratzel
added
2 - In Progress
improvement
seunghwak
reviewed
Jan 28, 2021
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
I will add more reviews but I think this will unblock you.
As I commented in the review, if we are reading the entire edge list in every GPU, we don't need to shuffle edges, we just need to locally filter out edges that do not belong to this GPU.
rlratzel
changed the title
…mms instances, added MPI_TRY, cleaned up comments.
…instead of manually updating paths.
… (not working yet).
…setting exec policy on remove_if to properly run on device.
…branch-0.18-pagerankmgtest
…ces belonging to each GPU.
…pagerankmgtest, first passing test: refactored utility to return renumber map and comparison maps to proper vertex now, still needs major cleanup and enabling of other tests.
…d CMakeLists.txt accordingly.
rlratzel
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1361 +/- ##
===============================================
+ Coverage 60.38% 60.67% +0.29%
===============================================
Files 67 69 +2
Lines 3029 3120 +91
===============================================
+ Hits 1829 1893 +64
- Misses 1200 1227 +27
Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Feb 8, 2021
Member
|
rerun tests |
aschaffer
requested changes
Feb 8, 2021
…of an edgelist, removed dead code.
Member
|
rerun tests |
…updated comments, added FIXMEs.
aschaffer
approved these changes
Feb 10, 2021
ChuckHastings
approved these changes
Feb 10, 2021
Collaborator
ChuckHastings
left a comment
ChuckHastings
left a comment
There was a problem hiding this comment.
Thanks for the updates.
Member
|
@gpucibot merge |
rapids-bot Bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
- [x] Add tests using graphs with isolated vertices - [x] Add personalized PageRank tests - [x] Test code refactoring - [x] Create libcugraphtestutil.a This PR fixes FIXMEs added in #1361 to address #1136 Authors: - Seunghwa Kang (@seunghwak) Approvers: - Rick Ratzel (@rlratzel) - Andrei Schaffer (@aschaffer) - Brad Rees (@BradReesWork) URL: #1419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added initial infrastructure for MG C++ testing and a Pagerank MG test using it.
Still a WIP, need to:Shuffle step is currently failinggraph_tctor expensive check is failingFinish comparison code to reference SG Pagerank resultsFix the#includeguard hack intest_utilities.hppLots of cleanupRefactor common steps into properSetUp()andTearDown()functionscloses #1136