Update C++ MG PageRank test#1419
Merged
rapids-bot[bot] merged 18 commits intorapidsai:branch-0.19from Mar 1, 2021
Merged
Conversation
… CUGRAPH_MG_TEST_PROGRAM_MAIN to set CUDA device before RMM initialization
…handle to graph_t (creates an empty graph)
…he executable name (MG_PAGERANK_TEST)
Contributor
Author
|
@rlratzel You may want to review this as this work is built on top of your work. |
seunghwak
added
3 - Ready for Review
improvement
rlratzel
approved these changes
Feb 26, 2021
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing the FIXMEs.
One thing I noticed is that one of the utilities in the previous version (create_graph_for_gpu) was removed in favor of inlining that code in the test. I was hoping we could move towards more reusable utilities for MG tests and less inlining, but your test is still easy enough to read so we can look into that in a future PR if necessary.
aschaffer
approved these changes
Feb 26, 2021
BradReesWork
approved these changes
Mar 1, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes FIXMEs added in #1361 to address #1136