Replace cuspatial#681
Conversation
…the ray-casting algorithm
AjayThorve
added
non-breaking
| Column name for the y-coordinates of the points. | ||
| polygon_coords : list of tuples or similar array-like | ||
| Coordinates of the polygon vertices, e.g., [(x1, y1), (x2, y2), ...]. | ||
| The polygon should be closed. |
There was a problem hiding this comment.
"closed" -- does this mean that the last vertex coordinates must be equal to the first vertex coordinates -- or that it assumes there is a line segment between the last and first vertex?
There was a problem hiding this comment.
Yes, closed here in this context means first and last vertex coordinates must be equal. The way lasso selection is setup in cuxfilter, the polygon will always be closed.
|
@AjayThorve Please also remove cuSpatial references from these files:
... and grep for anything else, please! |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Amazing! Thank you so much.
|
/merge |
|
Thanks all! 🙏 |
cuSpatial will not be published in 25.06: https://docs.rapids.ai/notices/rsn0045/ This PR drops cuSpatial from the nightly builds/tests. Depends on rapidsai/cuxfilter#681 and rapidsai/integration#757.
Previously cuSpatial was a dependency of cuxfilter. However the logic was rewritten to drop cuSpatial and drop the dependency in PR ( #681 ) as part of 25.06. However a few cuSpatial references were either missed or snuck back in 25.08. So this cleans them up Authors: - https://github.com/jakirkham Approvers: - Ajay Thorve (https://github.com/AjayThorve) - Bradley Dice (https://github.com/bdice) URL: #700
4 participants
Since cuspatial is being discontinued, We'd like to remove the dependency on cuspatial for the point-in-polygon method used in cuxfilter, specifically for lasso selection.
This PR fixes #678.
cc @jakirkham @bdice