Skip to content

Remove cuspatial and cuproj from rapids metapackage.#757

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.06from
bdice:remove-cuspatial
May 6, 2025
Merged

Remove cuspatial and cuproj from rapids metapackage.#757
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.06from
bdice:remove-cuspatial

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Apr 18, 2025

cuspatial and cuproj can be dropped from the rapids metapackage.

See https://docs.rapids.ai/notices/rsn0045/.

@bdice bdice requested a review from a team as a code owner April 18, 2025 18:26
@bdice bdice requested a review from KyleFromNVIDIA April 18, 2025 18:26
@jakirkham
Copy link
Copy Markdown
Member

Depends on PR: rapidsai/cuxfilter#681

@jakirkham
Copy link
Copy Markdown
Member

Closing and reopening to retest with updated cuxfilter binaries, which drop the cuspatial dependency

@jakirkham jakirkham closed this May 6, 2025
@jakirkham jakirkham reopened this May 6, 2025
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented May 6, 2025

Seeing this error on CI

Error: The following packages are missing dates in their build strings:
 - distributed-ucxx

It is not related to the changes here, but we will want to fix this

Edit: Looks like this is already fixed. Think we are just picking up old packages here

@jakirkham
Copy link
Copy Markdown
Member

Not sure if this is the issue. Though found one issue and submitted a small fix in PR: rapidsai/ucxx#410

@bdice bdice requested a review from a team as a code owner May 6, 2025 21:42
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented May 6, 2025

@jakirkham I pushed a fix to this repo. The problem was that distributed-ucxx had a date string at the beginning of the build string, and now that it's noarch it wasn't matching. That case of a noarch package wasn't accounted for in my original implementation of the nightly check script, and this fix should be merged.

Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! https://regexr.com/ helped me to understand the regex changes.

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented May 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit e4be3f0 into rapidsai:branch-25.06 May 6, 2025
18 checks passed
bdice added a commit to rapidsai/workflows that referenced this pull request May 6, 2025
cuSpatial will not be published in 25.06:
https://docs.rapids.ai/notices/rsn0045/

This PR drops cuSpatial from the nightly builds/tests.

Depends on rapidsai/cuxfilter#681 and
rapidsai/integration#757.
rapids-bot bot pushed a commit that referenced this pull request May 7, 2025
Contributes to rapidsai/shared-workflows#336

Reverts the testing changes from #757, ensuring that `test-conda-nightly-env` tests again run for every platform RAPIDS packages are built for.

And while I'm in here touching this, also updates `pre-commit` hooks to their latest versions with `pre-commit autoupdate`.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #760
rapids-bot bot pushed a commit that referenced this pull request Jul 15, 2025
Contributes to rapidsai/build-planning#197

Removes `cuspatial` and `cuproj` from the runtime dependencies of the `rapids` metapackage. The final releases of those packages were in RAPIDS 25.04.

## Notes for Reviewers

### Didn't we already do this?

Yes, #757 removed this for 25.06 (and that was forward-merged to 25.08).

But it looks like they were accidentally re-introduced in 25.08 via #772

And that technically worked because a small number of `cuspatial` and `cuproj` 25.08 nightlies did make it onto the `rapidsai-nightly` channel before we fully stopped development of `cuspatial`.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)

URL: #781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants