Skip to content

Port all conda recipes to rattler-build#772

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from
gforsyth:rattler-cleaner
Jun 3, 2025
Merged

Port all conda recipes to rattler-build#772
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from
gforsyth:rattler-cleaner

Conversation

@gforsyth
Copy link
Copy Markdown
Contributor

xref rapidsai/build-planning#47

Supercedes #771 which is a history mess

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented May 27, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gforsyth
Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@gforsyth
Copy link
Copy Markdown
Contributor Author

gforsyth commented Jun 3, 2025

/ok to test

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 3, 2025

/ok to test

@gforsyth, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@gforsyth
Copy link
Copy Markdown
Contributor Author

gforsyth commented Jun 3, 2025

/ok to test

@gforsyth gforsyth marked this pull request as ready for review June 3, 2025 15:16
@gforsyth gforsyth requested review from a team as code owners June 3, 2025 15:16
@gforsyth gforsyth requested a review from KyleFromNVIDIA June 3, 2025 15:16
@jameslamb jameslamb requested review from jameslamb and removed request for KyleFromNVIDIA June 3, 2025 15:44
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

This https://github.com/rapidsai/integration/blob/branch-25.08/conda/recipes/versions.yaml is one bit that's a bit different here compared to other RAPIDS projects, so I double-checked build logs to be sure those versions were getting pulled through... all looks good to me.

I left one note about removing CUDA 11 stuff in this PR. Do what you want with it, I don't feel strongly about doing it now vs. later in a follow-up PR.

Comment on lines +39 to +40
- if: cuda_major == "11"
then: cudatoolkit
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- if: cuda_major == "11"
then: cudatoolkit

Now that CUDA 11 support is getting dropped on 25.08 (rapidsai/build-planning#184), I think we could safely drop all the if: cuda_major == "11" stuff in any files you're already touching in this PR.

Notice that there aren't any CUDA 11 builds at https://github.com/rapidsai/integration/actions/runs/15421036533/job/43395979955?pr=772

image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that's a good shout!

Comment thread ci/build_python.sh

set -euo pipefail

rapids-configure-conda-channels
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thank you! Getting closer on rapidsai/gha-tools#145 😁

@gforsyth
Copy link
Copy Markdown
Contributor Author

gforsyth commented Jun 3, 2025

/merge

@rapids-bot rapids-bot bot merged commit 896e10f into rapidsai:branch-25.08 Jun 3, 2025
23 checks passed
@gforsyth gforsyth deleted the rattler-cleaner branch June 3, 2025 16:11
rapids-bot bot pushed a commit that referenced this pull request Jul 15, 2025
Contributes to rapidsai/build-planning#197

Removes `cuspatial` and `cuproj` from the runtime dependencies of the `rapids` metapackage. The final releases of those packages were in RAPIDS 25.04.

## Notes for Reviewers

### Didn't we already do this?

Yes, #757 removed this for 25.06 (and that was forward-merged to 25.08).

But it looks like they were accidentally re-introduced in 25.08 via #772

And that technically worked because a small number of `cuspatial` and `cuproj` 25.08 nightlies did make it onto the `rapidsai-nightly` channel before we fully stopped development of `cuspatial`.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)

URL: #781
AyodeAwe added a commit that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants