resolve warnings about casing in Dockerfiles#688
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-24.08from Jul 18, 2024
jameslamb:casing
Merged
resolve warnings about casing in Dockerfiles#688rapids-bot[bot] merged 6 commits intorapidsai:branch-24.08from jameslamb:casing
rapids-bot[bot] merged 6 commits intorapidsai:branch-24.08from
jameslamb:casing
Conversation
KyleFromNVIDIA
approved these changes
Jul 3, 2024
Member
Author
|
The notebook builds should hopefully be fixed once rapidsai/cuspatial#1404 is merged |
Member
Author
|
/ok to test |
Member
Author
|
A couple of |
Closed
Member
Author
|
Tests are passing here... looks like the fixes from #690 helped! |
Member
Author
|
/merge |
Member
|
Thanks James and Kyle! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been seeing this build warning in logs here:
(example build link)
That comes from BuildKit's build checks (https://docs.docker.com/reference/build-checks/). Details on that specific warning: https://docs.docker.com/reference/build-checks/from-as-casing/.
This fixes it, to remove a source of noise in logs (and because I agree with the suggestion that capitalizing keywords approves readability a bit).